support extra flags #452
Closed
support extra flags #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Example of where I'd like this |
7 tasks
fmeum
reviewed
Feb 8, 2025
| doc = ("Extra compile_flags, added after default values. " + | ||
| "`{toolchain_path_prefix}` in the flags will be substituted by the path " + | ||
| "to the root LLVM distribution directory. Provide one list for each " + | ||
| "target OS and arch pair you want to override " + |
Member
There was a problem hiding this comment.
override is misleading here, we are just adding flags.
If you just want to add a single flag (that is per platform) and leave the rest of the default flags, you have to copy out all the existing flags and add it to what you have. Instead support just adding an extra flag that is appended to the default flags.
fmeum
approved these changes
Feb 19, 2025
Contributor
Author
|
The alternative to all the extra flags is a way to "inject" the initial flags when providing the override flags, maybe via some magic value like $ORIGINAL_VALUES? |
auto-merge was automatically disabled
March 12, 2025 19:02
Pull request was closed
Member
|
@rockwotj Sorry, I didn't notice that auto-merge didn't go through (likely because of the unresolved comment). Feel free to reopen and I can merge - I think that more attributes are better than magic values in old ones. |
fmeum
pushed a commit
that referenced
this pull request
Sep 30, 2025
If you just want to add a single flag (that is per platform) and leave the rest of the default flags, you have to copy out all the existing flags and add it to what you have. Instead support just adding an extra flag that is appended to the default flags. This is a resubmit of #452 by @rockwotj with minor fixes in documentation. --------- Co-authored-by: Tyler Rockwood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you just want to add a single flag (that is per platform) and leave the rest of the default
flags, you have to copy out all the existing flags and add it to what
you have. Instead support just adding an extra flag that is appended to
the default flags.