toolchain: Set link_libs rather than link_flags
#624
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without this our TSAN/MSAN CI fails as it clobbers our setup to use the instrumented stdlib Signed-off-by: Ryan Northey <[email protected]>
phlax
requested review from
dzbarsky,
fmeum,
helly25,
jsharpe and
rrbutani
as code owners
Contributor
Author
|
im not sure if this is the best resolution - but i didnt find another way to make it work, and ive tested it quite a lot across our CI |
fmeum
approved these changes
Nov 26, 2025
Member
fmeum
left a comment
fmeum
left a comment
There was a problem hiding this comment.
It doesn't look worse, so let's try it 🙂
Collaborator
|
Should we also switch the libstdc++ lib flags for consistency? |
Contributor
Author
|
i can follow up later/tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without this our TSAN/MSAN CI fails as it clobbers our setup to use the instrumented stdlib