Skip to content

feat(docs): add testing guidelines for contributions#479

Merged
cameron-martin merged 1 commit intobazel-contrib:masterfrom
cbandera:feature/32-add-tests-to-contrib-guidelines
Nov 9, 2025
Merged

feat(docs): add testing guidelines for contributions#479
cameron-martin merged 1 commit intobazel-contrib:masterfrom
cbandera:feature/32-add-tests-to-contrib-guidelines

Conversation

@cbandera
Copy link
Collaborator

@cbandera cbandera commented Oct 9, 2025

This PR extends the contribution guidelines to mention the necessity of tests for new contributions.

Closes #32

BEGIN_COMMIT_OVERRIDE
docs: add testing guidelines for contributions
END_COMMIT_OVERRIDE

Copy link
Collaborator

@cameron-martin cameron-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cameron-martin cameron-martin enabled auto-merge (squash) November 8, 2025 20:56
@cameron-martin cameron-martin enabled auto-merge (squash) November 8, 2025 20:58
@cameron-martin
Copy link
Collaborator

Not sure why this won't merge. Maybe because of this?

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

@cameron-martin cameron-martin added the waiting-for-author Waiting for the PR author to address review feedback or make changes. label Nov 8, 2025
auto-merge was automatically disabled November 9, 2025 13:42

Head branch was pushed to by a user without write access

@cbandera cbandera force-pushed the feature/32-add-tests-to-contrib-guidelines branch from 1979db5 to dffa0fb Compare November 9, 2025 13:42
@cbandera
Copy link
Collaborator Author

cbandera commented Nov 9, 2025

@cameron-martin thanks for the hint. I have rebased onto the latest master and signed the commit. Must have missed that the last time.

@cameron-martin cameron-martin merged commit 2747be7 into bazel-contrib:master Nov 9, 2025
1 check passed
@cbandera cbandera deleted the feature/32-add-tests-to-contrib-guidelines branch December 7, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-author Waiting for the PR author to address review feedback or make changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests

2 participants