[email protected] #6435
Conversation
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (numactl) have been updated in this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the numactl module, version 2.0.19, to the Bazel Central Registry. The submission is well-structured, adheres to most BCR policies, and includes a comprehensive test module. I have a couple of suggestions for the BUILD.bazel overlay to improve correctness and usability. Additionally, as per the BCR style guide's strong suggestions, it would be beneficial to add a README.md in the modules/numactl/2.0.19/overlay/ directory to document the creation process of the BUILD.bazel file.
meteorcloudy
added
the
presubmit-auto-run
UebelAndre
force-pushed
the
numactl
branch
5 times, most recently
from
d2fefb4 to
c5c9fc7
Compare
|
@meteorcloudy friendly ping! |
|
@fmeum if you have a sec could I get a review on this one? |
| ) | ||
|
|
||
| # Common compiler flags | ||
| COMMON_COPTS = ["-Wall"] |
There was a problem hiding this comment.
Couldn't this cause warning spam if consumers use a different compiler? Protobuf has been doing this forever and it's always been very painful.
4 participants
No description provided.