Update imgui version to 1.92.4 and add more backends #6460
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| module( | ||
| name = "imgui", | ||
| version = "1.92.4", | ||
| bazel_compatibility = [">=7.2.1"], | ||
| compatibility_level = 0, | ||
| ) | ||
|
|
||
| bazel_dep(name = "platforms", version = "0.0.11") | ||
| bazel_dep(name = "rules_cc", version = "0.1.1") | ||
| bazel_dep(name = "glfw", version = "3.3.9") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| load("@rules_cc//cc:defs.bzl", "cc_library") | ||
|
|
||
| cc_library( | ||
| name = "imgui", | ||
| srcs = [ | ||
| "imgui.cpp", | ||
| "imgui_demo.cpp", | ||
| "imgui_draw.cpp", | ||
| "imgui_tables.cpp", | ||
| "imgui_widgets.cpp", | ||
| ], | ||
| hdrs = [ | ||
| "imconfig.h", | ||
| "imgui.h", | ||
| "imgui_internal.h", | ||
| "imstb_rectpack.h", | ||
| "imstb_textedit.h", | ||
| "imstb_truetype.h", | ||
| ], | ||
| include_prefix = "imgui", | ||
| visibility = ["//visibility:public"], | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../MODULE.bazel | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,173 @@ | ||
| load("@rules_cc//cc:defs.bzl", "cc_library") | ||
|
|
||
| package(default_visibility = ["//visibility:public"]) | ||
|
|
||
| cc_library( | ||
| name = "platform-glfw", | ||
| srcs = ["imgui_impl_glfw.cpp"], | ||
| hdrs = ["imgui_impl_glfw.h"], | ||
| include_prefix = "imgui", | ||
| includes = ["."], | ||
| linkopts = select({ | ||
| "@platforms//os:linux": [ | ||
| "-lpthread", | ||
| ], | ||
| "//conditions:default": [], | ||
| }), | ||
| # TODO: Remove this section after adding Windows support to @glfw: | ||
| # https://registry.bazel.build/modules/glfw | ||
| target_compatible_with = select({ | ||
| "@platforms//os:osx": [], | ||
| "@platforms//os:linux": [], | ||
| "//conditions:default": ["@platforms//:incompatible"], | ||
| }), | ||
| deps = [ | ||
| "//:imgui", | ||
| "@glfw", | ||
| ], | ||
| ) | ||
|
|
||
| cc_library( | ||
| name = "platform-win32", | ||
| srcs = ["imgui_impl_win32.cpp"], | ||
| hdrs = ["imgui_impl_win32.h"], | ||
| include_prefix = "imgui", | ||
| includes = ["."], | ||
| target_compatible_with = [ | ||
| "@platforms//os:windows", | ||
| ], | ||
| deps = [ | ||
| "//:imgui", | ||
| ], | ||
| ) | ||
|
|
||
| cc_library( | ||
| name = "platform-sdl2", | ||
| srcs = ["imgui_impl_sdl2.cpp"], | ||
| hdrs = ["imgui_impl_sdl2.h"], | ||
| copts = ["-I/usr/include/SDL2"], | ||
| include_prefix = "imgui", | ||
| includes = ["."], | ||
| linkopts = ["-lSDL2"], | ||
| deps = ["//:imgui"], | ||
| ) | ||
|
Comment on lines
+44
to
+53
Contributor
There was a problem hiding this comment. The use of hardcoded paths like Style Guide ReferencesFootnotes |
||
|
|
||
| cc_library( | ||
| name = "renderer-opengl3", | ||
| srcs = ["imgui_impl_opengl3.cpp"], | ||
| hdrs = [ | ||
| "imgui_impl_opengl3.h", | ||
| "imgui_impl_opengl3_loader.h", | ||
| ], | ||
| include_prefix = "imgui", | ||
| includes = ["."], | ||
| linkopts = select({ | ||
| "@rules_cc//cc/compiler:msvc-cl": [ | ||
| "/DEFAULTLIB:opengl32", | ||
| ], | ||
| "@rules_cc//cc/compiler:clang-cl": [ | ||
| "/DEFAULTLIB:opengl32", | ||
| ], | ||
| "@bazel_tools//src/conditions:linux_x86_64": [ | ||
| "-lGL", | ||
| "-ldl", | ||
| ], | ||
| "//conditions:default": [], | ||
| }), | ||
| deps = [ | ||
| "//:imgui", | ||
| ], | ||
| ) | ||
|
|
||
| cc_library( | ||
| name = "renderer-dx9", | ||
| srcs = ["imgui_impl_dx9.cpp"], | ||
| hdrs = ["imgui_impl_dx9.h"], | ||
| include_prefix = "imgui", | ||
| includes = ["."], | ||
| linkopts = select({ | ||
| "@rules_cc//cc/compiler:msvc-cl": [ | ||
| "/DEFAULTLIB:D3D9", | ||
| ], | ||
| "@rules_cc//cc/compiler:clang-cl": [ | ||
| "/DEFAULTLIB:D3D9", | ||
| ], | ||
| }), | ||
| target_compatible_with = [ | ||
| "@platforms//os:windows", | ||
| ], | ||
| deps = ["//:imgui"], | ||
| ) | ||
|
|
||
| cc_library( | ||
| name = "renderer-dx10", | ||
| srcs = ["imgui_impl_dx10.cpp"], | ||
| hdrs = ["imgui_impl_dx10.h"], | ||
| include_prefix = "imgui", | ||
| includes = ["."], | ||
| linkopts = select({ | ||
| "@rules_cc//cc/compiler:msvc-cl": [ | ||
| "/DEFAULTLIB:D3D10", | ||
| ], | ||
| "@rules_cc//cc/compiler:clang-cl": [ | ||
| "/DEFAULTLIB:D3D10", | ||
| ], | ||
| }), | ||
| target_compatible_with = [ | ||
| "@platforms//os:windows", | ||
| ], | ||
| deps = ["//:imgui"], | ||
| ) | ||
|
|
||
| cc_library( | ||
| name = "renderer-dx11", | ||
| srcs = ["imgui_impl_dx11.cpp"], | ||
| hdrs = ["imgui_impl_dx11.h"], | ||
| include_prefix = "imgui", | ||
| includes = ["."], | ||
| linkopts = select({ | ||
| "@rules_cc//cc/compiler:msvc-cl": [ | ||
| "/DEFAULTLIB:D3D11", | ||
| ], | ||
| "@rules_cc//cc/compiler:clang-cl": [ | ||
| "/DEFAULTLIB:D3D11", | ||
| ], | ||
| }), | ||
| target_compatible_with = [ | ||
| "@platforms//os:windows", | ||
| ], | ||
| deps = ["//:imgui"], | ||
| ) | ||
|
|
||
| cc_library( | ||
| name = "renderer-dx12", | ||
| srcs = ["imgui_impl_dx12.cpp"], | ||
| hdrs = ["imgui_impl_dx12.h"], | ||
| include_prefix = "imgui", | ||
| includes = ["."], | ||
| linkopts = select({ | ||
| "@rules_cc//cc/compiler:msvc-cl": [ | ||
| "/DEFAULTLIB:D3D12", | ||
| "/DEFAULTLIB:DXGI", | ||
| ], | ||
| "@rules_cc//cc/compiler:clang-cl": [ | ||
| "/DEFAULTLIB:D3D12", | ||
| "/DEFAULTLIB:DXGI", | ||
| ], | ||
| }), | ||
| target_compatible_with = [ | ||
| "@platforms//os:windows", | ||
| ], | ||
| deps = ["//:imgui"], | ||
| ) | ||
|
|
||
| cc_library( | ||
| name = "renderer-sdl2", | ||
| srcs = ["imgui_impl_sdlrenderer2.cpp"], | ||
| hdrs = ["imgui_impl_sdlrenderer2.h"], | ||
| copts = ["-I/usr/include/SDL2"], | ||
| include_prefix = "imgui", | ||
| includes = ["."], | ||
| linkopts = ["-lSDL2"], | ||
| deps = ["//:imgui"], | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| load("@rules_cc//cc:defs.bzl", "cc_binary") | ||
|
|
||
| cc_binary( | ||
| name = "example_glfw_opengl3", | ||
| srcs = ["main.cpp"], | ||
| deps = [ | ||
| "//:imgui", | ||
| "//backends:platform-glfw", | ||
| "//backends:renderer-opengl3", | ||
| ], | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| load("@rules_cc//cc:defs.bzl", "cc_binary") | ||
|
|
||
| cc_binary( | ||
| name = "example_sdl2_sdlrenderer2", | ||
| srcs = ["main.cpp"], | ||
| copts = ["-I/usr/include/SDL2"], | ||
|
Contributor
There was a problem hiding this comment. This hardcoded include path Style Guide ReferencesFootnotes
|
||
| deps = [ | ||
| "//:imgui", | ||
| "//backends:platform-sdl2", | ||
| "//backends:renderer-sdl2", | ||
| ], | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| load("@rules_cc//cc:defs.bzl", "cc_binary") | ||
|
|
||
| cc_binary( | ||
| name = "example_win32_directx10", | ||
| srcs = ["main.cpp"], | ||
| deps = [ | ||
| "//:imgui", | ||
| "//backends:platform-win32", | ||
| "//backends:renderer-dx10", | ||
| ], | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| load("@rules_cc//cc:defs.bzl", "cc_binary") | ||
|
|
||
| cc_binary( | ||
| name = "example_win32_directx11", | ||
| srcs = ["main.cpp"], | ||
| deps = [ | ||
| "//:imgui", | ||
| "//backends:platform-win32", | ||
| "//backends:renderer-dx11", | ||
| ], | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| load("@rules_cc//cc:defs.bzl", "cc_binary") | ||
|
|
||
| cc_binary( | ||
| name = "example_win32_directx12", | ||
| srcs = ["main.cpp"], | ||
| deps = [ | ||
| "//:imgui", | ||
| "//backends:platform-win32", | ||
| "//backends:renderer-dx12", | ||
| ], | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| load("@rules_cc//cc:defs.bzl", "cc_binary") | ||
|
|
||
| cc_binary( | ||
| name = "example_win32_directx9", | ||
| srcs = ["main.cpp"], | ||
| deps = [ | ||
| "//:imgui", | ||
| "//backends:platform-win32", | ||
| "//backends:renderer-dx9", | ||
| ], | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| load("@rules_cc//cc:defs.bzl", "cc_binary") | ||
|
|
||
| cc_binary( | ||
| name = "example_win32_opengl3", | ||
| srcs = ["main.cpp"], | ||
| deps = [ | ||
| "//:imgui", | ||
| "//backends:platform-win32", | ||
| "//backends:renderer-opengl3", | ||
| ], | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| matrix: | ||
| linux_platform: ["ubuntu2004"] | ||
| osx_platform: ["macos", "macos_arm64"] | ||
| bazel: [7.x, 8.x] | ||
|
|
||
| tasks: | ||
| verify_windows_targets: | ||
| name: Verify windows build and test targets | ||
| platform: windows | ||
| bazel: ${{ bazel }} | ||
| build_targets: | ||
| - '@imgui//...' | ||
| verify_linux_targets: | ||
| name: Verify linux build and test targets | ||
| platform: ${{ linux_platform }} | ||
| shell_commands: | ||
| # X11 requires libx11-dev and a few other system packages, all in xorg-dev. | ||
| # See https://www.glfw.org/docs/latest/compile.html#compile_deps | ||
| - sudo apt-get update | ||
| - sudo apt-get install xorg-dev libgl1-mesa-dev -y | ||
|
Contributor
There was a problem hiding this comment. The presubmit configuration for Linux is missing the development package for SDL2. Since you are adding an SDL2 backend and example, - sudo apt-get install xorg-dev libgl1-mesa-dev libsdl2-dev -y |
||
| bazel: ${{ bazel }} | ||
| build_targets: | ||
| - '@imgui//...' | ||
| verify_osx_targets: | ||
| name: Verify osx build and test targets | ||
| platform: ${{ osx_platform }} | ||
| bazel: ${{ bazel }} | ||
| build_targets: | ||
| - '@imgui//...' | ||
| build_flags: | ||
| - "--repo_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "integrity": "sha256-DhddTZQRElMlSbQYztC9VGq+kCTsubX0MfimeiGXsLo=", | ||
| "strip_prefix": "imgui-1.92.4", | ||
| "url": "https://github.com/ocornut/imgui/archive/refs/tags/v1.92.4.tar.gz", | ||
| "patch_strip": 1, | ||
| "overlay": { | ||
| "BUILD.bazel": "sha256-gZo/FwvLbNU6xL0XX61/Wbkx2BN5j1goWLLAyye5tQc=", | ||
| "MODULE.bazel": "sha256-Mq/j8eIq2bwk/eMnt+9Y5EtG4tmChoN4jiXcSzYFNPQ=", | ||
| "backends/BUILD.bazel": "sha256-wISTqVHxwvRmxGMxsDkcX8WSIRHV4mocK2xB4BtZ1l4=", | ||
| "examples/example_glfw_opengl3/BUILD.bazel": "sha256-wTdD4nkg3rvQmg3bPjU2GJTsw5Lry9GYN/mnxMzZe8E=", | ||
| "examples/example_sdl2_sdlrenderer2/BUILD.bazel": "sha256-m0crGOr4b/QeQVlTxXbcGR2jrZvI7N2iXtIFNS0XkRA=", | ||
| "examples/example_win32_directx10/BUILD.bazel": "sha256-DaG4vRl9qrZq4U4sWEUNM1fq6Ws4Ey8uBT/EyhlWDTE=", | ||
| "examples/example_win32_directx11/BUILD.bazel": "sha256-M9ws7BtFRjWtgJR9uc+stezYOqTNUhIWUUytUiEEAJQ=", | ||
| "examples/example_win32_directx12/BUILD.bazel": "sha256-Z+2SJGxHEVE78bdTh0FCAcdzr+42/hXzHev1WoBAVcs=", | ||
| "examples/example_win32_directx9/BUILD.bazel": "sha256-LzJiJDgzJFY/ZPQraDEo5es/w+zZW2Jwm7JgKBXOg2M=", | ||
| "examples/example_win32_opengl3/BUILD.bazel": "sha256-9tzKuBS9mclm/vZiJYesPmCt14lGIihD84lJVOm2QS8=" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Symlinks are not allowed anymore - replace this with a copy of
MODULE.bazel