-
Notifications
You must be signed in to change notification settings - Fork 593
Add OpenUSD module #6532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenUSD module #6532
Conversation
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (openusd) have been updated in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new Bazel module for OpenUSD version 25.11. The module is well-structured, providing a monolithic static library and a test to verify the build, which aligns with the BCR guidelines.
My review has identified a few high-severity issues that should be addressed:
- There is a redundant
MODULE.bazelfile in theoverlaydirectory which should be removed. - The
BUILDfile in the overlay hardcodes build parallelism, which should be left for Bazel to manage. - The new
README.mdcontains user-specific paths in example commands, which should be replaced with placeholders. - Additionally, the
README.mdfile should be placed within the version-specific directory (25.11/) as suggested by the BCR style guide for better version-specific documentation.
Once these points are addressed, this will be a great addition to the BCR.
modules/openusd/25.11/overlay/BUILD
Outdated
| }, | ||
| env = { | ||
| "CMAKE_BUILD_TYPE": "Release", | ||
| "CMAKE_BUILD_PARALLEL_LEVEL": "16", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think bazel cmake() rule with set this properly unless we specify it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is somewhat accurate: Bazel doesn't know that this will use 16 jobs, so it will likely run too many actions concurrently, which could slow down the overall progress or consume too much memory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is somewhat accurate: Bazel doesn't know that this will use 16 jobs, so it will likely run too many actions concurrently, which could slow down the overall progress or consume too much memory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fmeum , is the best practice to remove both the -j<threads> and CMAKE_BUILD_PARALLEL_LEVEL here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this to use CMAKE_BUILD_PARRALEL_LEVEL of 4 here, which seems like a reasonable compromise. Most of the other uses of the cmake() rule I've seen seem to do the same.
|
@bazel-io skip_check unstable_url |
|
CC @dgoel - This is the PR to add OpenUSD to the bazel central registry. |
This adds an OpenUSD module, starting at version 25.11. It provides a target
@openusd//:openusdto link OpenUSD as a C++ static library and a target@openusd//:plugin_filesfor specifying the default plugin files as a data dependency.@bazel-io skip_check unstable_url