Skip to content

Conversation

@mgriley
Copy link
Contributor

@mgriley mgriley commented Nov 13, 2025

This adds an OpenUSD module, starting at version 25.11. It provides a target @openusd//:openusd to link OpenUSD as a C++ static library and a target @openusd//:plugin_files for specifying the default plugin files as a data dependency.

@bazel-io skip_check unstable_url

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (openusd) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new Bazel module for OpenUSD version 25.11. The module is well-structured, providing a monolithic static library and a test to verify the build, which aligns with the BCR guidelines.

My review has identified a few high-severity issues that should be addressed:

  • There is a redundant MODULE.bazel file in the overlay directory which should be removed.
  • The BUILD file in the overlay hardcodes build parallelism, which should be left for Bazel to manage.
  • The new README.md contains user-specific paths in example commands, which should be replaced with placeholders.
  • Additionally, the README.md file should be placed within the version-specific directory (25.11/) as suggested by the BCR style guide for better version-specific documentation.

Once these points are addressed, this will be a great addition to the BCR.

},
env = {
"CMAKE_BUILD_TYPE": "Release",
"CMAKE_BUILD_PARALLEL_LEVEL": "16",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Similar to the -j16 build argument, hardcoding CMAKE_BUILD_PARALLEL_LEVEL is not recommended. This overrides Bazel's job management. Please remove this environment variable to allow Bazel to control build parallelism.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think bazel cmake() rule with set this properly unless we specify it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is somewhat accurate: Bazel doesn't know that this will use 16 jobs, so it will likely run too many actions concurrently, which could slow down the overall progress or consume too much memory.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is somewhat accurate: Bazel doesn't know that this will use 16 jobs, so it will likely run too many actions concurrently, which could slow down the overall progress or consume too much memory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmeum , is the best practice to remove both the -j<threads> and CMAKE_BUILD_PARALLEL_LEVEL here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this to use CMAKE_BUILD_PARRALEL_LEVEL of 4 here, which seems like a reasonable compromise. Most of the other uses of the cmake() rule I've seen seem to do the same.

@mgriley
Copy link
Contributor Author

mgriley commented Nov 13, 2025

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Nov 13, 2025
@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Nov 13, 2025
@mgriley
Copy link
Contributor Author

mgriley commented Nov 13, 2025

CC @dgoel - This is the PR to add OpenUSD to the bazel central registry.

@fmeum fmeum merged commit 98d242c into bazelbuild:main Nov 15, 2025
11 checks passed
@mgriley mgriley deleted the add-openusd branch November 17, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants