Skip to content

Conversation

@bu3
Copy link
Contributor

@bu3 bu3 commented Nov 14, 2025

@bazel-io skip_check incompatible_flags

@bazel-io
Copy link
Member

Hello @wing328, @nucle, @BradHolmes, modules you maintain (openapi_tools_generator_bazel) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds version 0.2.2 for the openapi_tools_generator_bazel module. The overall structure and file contents align with the Bazel Central Registry policies. However, I've found a critical issue in the provided patch file. The patch file contains an invalid header line which will likely cause the source patching to fail. Please address this issue to ensure the module can be correctly consumed.

@@ -0,0 +1,12 @@
===================================================================
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This header line is not part of the standard unified diff format and will likely cause the patch command to fail. Please remove it to ensure the patch can be applied correctly.

@kotlaja kotlaja added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Nov 14, 2025
@bu3
Copy link
Contributor Author

bu3 commented Nov 17, 2025

@bazel-io skip_check incompatible_flags

@bazel-io bazel-io added the skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit label Nov 17, 2025
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@bazel-io bazel-io merged commit b15d1e3 into bazelbuild:main Nov 17, 2025
18 checks passed
@bazel-io bazel-io added the auto-merged This PR is automatically merged by the BCR reviewer bot. label Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merged This PR is automatically merged by the BCR reviewer bot. presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants