Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions modules/boost.assign/1.83.0.bcr.1/MODULE.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
module(
name = "boost.assign",
version = "1.83.0.bcr.1",
bazel_compatibility = [">=7.2.1"],
compatibility_level = 108300,
)

bazel_dep(name = "boost.array", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.config", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.core", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.move", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.multi_index", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.preprocessor", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.ptr_container", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.range", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.static_assert", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.test", version = "1.83.0.bcr.1")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The dependency on boost.test is for running tests and is not a required dependency for the library itself. It should be marked as a development dependency by adding dev_dependency = True. This prevents downstream users from unnecessarily fetching test-only dependencies.

Suggested change
bazel_dep(name = "boost.test", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.test", version = "1.83.0.bcr.1", dev_dependency = True)

bazel_dep(name = "boost.throw_exception", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.tuple", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.type_traits", version = "1.83.0.bcr.1")
bazel_dep(name = "rules_cc", version = "0.0.14")
33 changes: 33 additions & 0 deletions modules/boost.assign/1.83.0.bcr.1/overlay/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
load("@rules_cc//cc:defs.bzl", "cc_library")

package(default_visibility = ["//visibility:public"])

cc_library(
name = "boost.assign",
hdrs = glob(
[
"include/**/*.hpp",
],
exclude = [
"include/boost/assign.hpp",
],
),
features = [
"parse_headers",
],
includes = ["include"],
textual_hdrs = ["include/boost/assign.hpp"],
deps = [
"@boost.array",
"@boost.config",
"@boost.core",
"@boost.move",
"@boost.preprocessor",
"@boost.ptr_container",
"@boost.range",
"@boost.static_assert",
"@boost.throw_exception",
"@boost.tuple",
"@boost.type_traits",
],
Comment on lines +20 to +32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The cc_library for boost.assign is missing a dependency on @boost.multi_index. According to the Boost documentation, boost.assign depends on boost.multi_index. Please add it to the deps list to ensure the module builds correctly for consumers.

    deps = [
        "@boost.array",
        "@boost.config",
        "@boost.core",
        "@boost.move",
        "@boost.multi_index",
        "@boost.preprocessor",
        "@boost.ptr_container",
        "@boost.range",
        "@boost.static_assert",
        "@boost.throw_exception",
        "@boost.tuple",
        "@boost.type_traits",
    ],

)
21 changes: 21 additions & 0 deletions modules/boost.assign/1.83.0.bcr.1/overlay/MODULE.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
module(
name = "boost.assign",
version = "1.83.0.bcr.1",
bazel_compatibility = [">=7.2.1"],
compatibility_level = 108300,
)

bazel_dep(name = "boost.array", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.config", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.core", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.move", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.multi_index", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.preprocessor", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.ptr_container", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.range", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.static_assert", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.test", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.throw_exception", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.tuple", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.type_traits", version = "1.83.0.bcr.1")
bazel_dep(name = "rules_cc", version = "0.0.14")
20 changes: 20 additions & 0 deletions modules/boost.assign/1.83.0.bcr.1/presubmit.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
matrix:
platform:
- debian10
- debian11
- macos
- macos_arm64
- ubuntu2004
- ubuntu2204
- ubuntu2404
- windows
bazel: [7.x, rolling]
tasks:
verify_targets:
name: Verify build targets
platform: ${{ platform }}
bazel: ${{ bazel }}
build_flags:
- '--process_headers_in_dependencies'
build_targets:
- '@boost.assign//:boost.assign'
9 changes: 9 additions & 0 deletions modules/boost.assign/1.83.0.bcr.1/source.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"integrity": "sha256-HHZKV4rwNH+NGldsGo7YQ7goD0oDXPIH48y+N3I58CI=",
"strip_prefix": "assign-boost-1.83.0",
"url": "https://github.com/boostorg/assign/archive/refs/tags/boost-1.83.0.tar.gz",
"overlay": {
"BUILD.bazel": "sha256-7EmzmzMy3eS0hq5YlE7RFxhZr4phb+Ou66ThsDIQNoQ=",
"MODULE.bazel": "sha256-sWIF6LDbOXXxPbS7dIMXa9IFOQo8j5vTTXUWOkImMiw="
}
}
1 change: 1 addition & 0 deletions modules/boost.assign/metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"github:boostorg/assign"
],
"versions": [
"1.83.0.bcr.1",
"1.87.0",
"1.88.0.bcr.1",
"1.88.0.bcr.2",
Expand Down
17 changes: 17 additions & 0 deletions modules/boost.timer/1.83.0.bcr.1/MODULE.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
module(
name = "boost.timer",
version = "1.83.0.bcr.1",
bazel_compatibility = [">=7.2.1"], # need support for "overlay" directory
compatibility_level = 108300,
)

bazel_dep(name = "boost.config", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.io", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.predef", version = "1.83.0.bcr.1")
bazel_dep(name = "platforms", version = "0.0.10")
bazel_dep(name = "rules_cc", version = "0.0.14")

# For tests
bazel_dep(name = "boost.chrono", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.core", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.detail", version = "1.83.0.bcr.1")
Comment on lines +15 to +17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The dependencies boost.chrono, boost.core, and boost.detail are only used for tests, as indicated by the comment and their usage in overlay/BUILD.bazel. They should be marked as development dependencies by adding dev_dependency = True to each. This prevents downstream users from unnecessarily fetching test-only dependencies.

Suggested change
bazel_dep(name = "boost.chrono", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.core", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.detail", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.chrono", version = "1.83.0.bcr.1", dev_dependency = True)
bazel_dep(name = "boost.core", version = "1.83.0.bcr.1", dev_dependency = True)
bazel_dep(name = "boost.detail", version = "1.83.0.bcr.1", dev_dependency = True)

66 changes: 66 additions & 0 deletions modules/boost.timer/1.83.0.bcr.1/overlay/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test")

cc_library(
name = "boost.timer",
srcs = glob(["src/*.cpp"]),
hdrs = glob(
["include/**/*.hpp"],
# These headers are deprecated and should not be used.
exclude = [
"include/boost/progress.hpp",
"include/boost/timer.hpp",
],
),
features = ["parse_headers"],
includes = ["include"],
visibility = ["//visibility:public"],
deps = [
"@boost.config",
"@boost.io",
"@boost.predef",
],
)

cc_test(
name = "chrono_conflict_test",
srcs = ["test/chrono_conflict_test.cpp"],
deps = [
":boost.timer",
"@boost.chrono",
],
)

cc_test(
name = "cpu_timer_info_test",
srcs = ["test/cpu_timer_info.cpp"],
local_defines = select({
"@platforms//os:windows": ["BOOST_ALL_NO_LIB"],
"//conditions:default": [],
}),
deps = [
":boost.timer",
"@boost.detail",
],
)

cc_test(
name = "cpu_timer_test",
srcs = ["test/cpu_timer_test.cpp"],
local_defines = select({
"@platforms//os:windows": ["BOOST_ALL_NO_LIB"],
"//conditions:default": [],
}),
deps = [
":boost.timer",
"@boost.detail",
],
)

cc_test(
name = "progress_display_test",
srcs = ["test/progress_display_test.cpp"],
deps = [
":boost.timer",
"@boost.core",
],
)
17 changes: 17 additions & 0 deletions modules/boost.timer/1.83.0.bcr.1/overlay/MODULE.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
module(
name = "boost.timer",
version = "1.83.0.bcr.1",
bazel_compatibility = [">=7.2.1"], # need support for "overlay" directory
compatibility_level = 108300,
)

bazel_dep(name = "boost.config", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.io", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.predef", version = "1.83.0.bcr.1")
bazel_dep(name = "platforms", version = "0.0.10")
bazel_dep(name = "rules_cc", version = "0.0.14")

# For tests
bazel_dep(name = "boost.chrono", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.core", version = "1.83.0.bcr.1")
bazel_dep(name = "boost.detail", version = "1.83.0.bcr.1")
24 changes: 24 additions & 0 deletions modules/boost.timer/1.83.0.bcr.1/presubmit.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
matrix:
platform:
- debian10
- debian11
- ubuntu2004
- ubuntu2204
- ubuntu2404
- macos
- macos_arm64
- windows
bazel: [7.x, rolling]
tasks:
verify_targets:
platform: ${{ platform }}
bazel: ${{ bazel }}
build_flags:
- "--process_headers_in_dependencies"
build_targets:
- "@boost.timer"
test_flags:
- "--process_headers_in_dependencies"
test_targets:
- "@boost.timer//:all"

9 changes: 9 additions & 0 deletions modules/boost.timer/1.83.0.bcr.1/source.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"url": "https://github.com/boostorg/timer/archive/refs/tags/boost-1.83.0.tar.gz",
"integrity": "sha256-CGzESZRhRsrUlZCiwYSbcpJehk2qMWt7dHvEvgeFht8=",
"strip_prefix": "timer-boost-1.83.0",
"overlay": {
"BUILD.bazel": "sha256-yon4tnV0Qr3tqLtSYYoUJwz88QVfBExIrtEuoaGYZCU=",
"MODULE.bazel": "sha256-u3Nvlt1SmQKh7v8550716RFBMsSNDiisy0TqBAG7sTQ="
}
}
1 change: 1 addition & 0 deletions modules/boost.timer/metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"github:boostorg/timer"
],
"versions": [
"1.83.0.bcr.1",
"1.87.0",
"1.88.0.bcr.1",
"1.88.0.bcr.2",
Expand Down
Loading