Skip to content

Conversation

@matthias-giersch
Copy link
Contributor

Adds fkYAML version 0.4.2 (https://github.com/fktn-k/fkYAML) to BCR.

@google-cla
Copy link

google-cla bot commented Nov 14, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (fkyaml) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds fkyaml version 0.4.2 to the Bazel Central Registry. The changes are well-structured and mostly follow the BCR guidelines. I've found one issue regarding the bazel_compatibility attribute missing in the overlay's MODULE.bazel file, which is recommended by the style guide. Please address this to ensure forward compatibility. Otherwise, the submission looks good.

@Wyverald Wyverald added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Nov 14, 2025
@meteorcloudy meteorcloudy merged commit 34994c6 into bazelbuild:main Nov 17, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants