Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Member
|
Hello @chrispsommers, @matthewtlam, modules you maintain (p4runtime) have been updated in this PR. |
smolkaj
force-pushed
the
add-p4runtime-1.5.0.bcr.1
branch
2 times, most recently
from
5d60ae4 to
ec651cd
Compare
The 1.5.0 BCR entry declares bazel_compatibility = [">=7.0.0", "<9.0.0"], blocking downstream users from upgrading to Bazel 9. The upper bound is overly conservative; no Bazel-9-specific incompatibilities exist. This new .bcr.1 release removes it so BCR users can adopt Bazel 9. The upstream fix is tracked at p4lang/p4runtime#597. Changes from 1.5.0: - MODULE.bazel: remove upper bound, bump version to 1.5.0.bcr.1, add re2 dependency (required by gRPC on Bazel 9), update googleapis/grpc/protobuf to latest BCR versions - proto/p4/{config/v1,v1}/BUILD.bazel: load proto_library from @protobuf//bazel rather than the deprecated @rules_proto - presubmit.yml: test on Bazel 7.x and 9.x
smolkaj
force-pushed
the
add-p4runtime-1.5.0.bcr.1
branch
from
c21d76e to
a035653
Compare
bazel-io
approved these changes
Feb 28, 2026
Member
bazel-io
left a comment
bazel-io
left a comment
There was a problem hiding this comment.
All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.
bazel-io
added
the
presubmit-auto-run
bazel-io
added
the
auto-merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The 1.5.0 BCR entry declares
bazel_compatibility = [">=7.0.0", "<9.0.0"],blocking downstream users from upgrading to Bazel 9. The upper bound is overly
conservative — no Bazel-9-specific incompatibilities were found. This entry
adds a
.bcr.1release that removes it so BCR users can adopt Bazel 9.The upstream fix is tracked at p4lang/p4runtime#597.
Implementation
A single patch (
fix_bazel_files.patch) transforms the raw source tarball intothe desired state, mirroring the structure of the existing
1.5.0entry:MODULE.bazel: remove upper bound and TODO comment, bump version to1.5.0.bcr.1, addre2dep (required by gRPC on Bazel 9), updategoogleapis/grpc/protobufto latest BCR versionsproto/p4/{config/v1,v1}/BUILD.bazel: loadproto_libraryfrom@protobuf//bazelrather than the deprecated@rules_protopresubmit.yml: test on Bazel 7.x and 9.x