Open
Conversation
This brings in the `purl` field that is increasingly used by other libraries. In the `bzlmod` world this is less important, but for folks using workspace-based builds, skylib tends to be loaded early so any deps it brings in normally end up being used.
shs96c
requested review from
brandjon,
c-mita,
comius,
hvadehra and
tetromino
as code owners
|
|
||
| bazel_dep(name = "platforms", version = "0.0.4") | ||
| bazel_dep(name = "rules_license", version = "0.0.7") | ||
| bazel_dep(name = "rules_license", version = "1.0.0") |
There was a problem hiding this comment.
Do we want to force 1.0.0 on people? I'm only asking because MODULE.bazel should declare the minimum version needed.
Contributor
Author
There was a problem hiding this comment.
It should be fine to update everyone to use 1.0.0: it's not hugely different from the previous release and I don't think it introduces new dependencies. OTOH, it includes the purl attribute in the PackageInfo which is useful when generating SBOMs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings in the
purlfield that is increasingly used by other libraries. In thebzlmodworld this is less important, but for folks using workspace-based builds, skylib tends to be loaded early so any deps it brings in normally end up being used.