Open
Conversation
tillahoffmann
requested review from
brandjon,
c-mita,
comius,
hvadehra and
tetromino
as code owners
|
Could one of the reviewers have a look? 🙏 Thanks! |
tillahoffmann
force-pushed
the
itertools
branch
from
3412802 to
5afd65a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a module implementing the functionality of Python's
itertoolspackage. I originally implemented this a few years ago to run machine learning experiments, mostly to generate cartesian products of learning rate schedule, optimizer, etc.@jjmaestro recently suggested it would be useful to have this functionality available in Skylib.
The implementation here is WIP as it is missing markdown files in the
docsdirectory. I thought I'd get your feedback before getting into writing docs beyond docstrings.