Open
Conversation
mattyclarkson
commented
Jun 13, 2025
mattyclarkson
commented
mattyclarkson
requested review from
brandjon,
c-mita,
comius,
hvadehra and
tetromino
as code owners
fmeum
reviewed
Jun 13, 2025
mattyclarkson
force-pushed
the
structs.merge
branch
4 times, most recently
from
2ab03ac to
5b52c11
Compare
Author
|
I am unclear why this is failing the
Maybe an infra-failure? |
fmeum
reviewed
Jun 20, 2025
mattyclarkson
force-pushed
the
structs.merge
branch
2 times, most recently
from
0f512a9 to
7e4dd74
Compare
Copy/paste error.
`to_json`/`to_proto` function have been removed from `structs`. Check that they are built-in functions before eliminating the keys. Tests are gated behind `bazel_features.rules.no_struct_field_denylist` to prevent breakage on old Bazel when running the tests.
mattyclarkson
force-pushed
the
structs.merge
branch
from
7e4dd74 to
3746c52
Compare
`to_json`/`to_proto` function have been removed from `structs`. Check that they are built-in functions before eliminating the keys. Tests are gated behind `bazel_features.rules.no_struct_field_denylist` to prevent breakage on old Bazel when running the tests.
Author
|
I learnt how to read the BuildKite annotations tab 😊 |
Author
|
@fmeum this is good to go. |
Contributor
|
@mattyclarkson I don't have write access, I can just help you get this in your shape for review by Google folks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.