Expand make variables in expand_template values#606
Open
ouillie wants to merge 3 commits intobazelbuild:mainfrom
Open
Expand make variables in expand_template values#606ouillie wants to merge 3 commits intobazelbuild:mainfrom
ouillie wants to merge 3 commits intobazelbuild:mainfrom
Conversation
ouillie
requested review from
brandjon,
c-mita,
comius,
hvadehra and
tetromino
as code owners
Author
|
Happy to discuss adjustments if this is not mergeable as-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses half of #442 (which should probably be 2 separate tickets).