Adding type testing for Targets, Labels, and Files#614
Open
alphalex-google wants to merge 2 commits intobazelbuild:mainfrom
Open
Adding type testing for Targets, Labels, and Files#614alphalex-google wants to merge 2 commits intobazelbuild:mainfrom
alphalex-google wants to merge 2 commits intobazelbuild:mainfrom
Conversation
While these types cannot be created in the loading phase (i.e. `value = type(File())`) for internally consistent type checking, these type rituals allow for a central definition of how/where this type checking can be governed, allowing for future changes, etc to all become generationall compatible as appropriate.
alphalex-google
requested review from
brandjon,
c-mita,
comius,
hvadehra and
tetromino
as code owners
tetromino
reviewed
Feb 13, 2026
Collaborator
tetromino
left a comment
tetromino
left a comment
There was a problem hiding this comment.
LGTM. I think CI is failing because docs need to be regenerated; let me take a look
tetromino
approved these changes
Feb 13, 2026
tetromino
requested changes
Feb 13, 2026
Collaborator
There was a problem hiding this comment.
@alphalex-google - please run bazelisk run //docs:update to regenerate docs/types_doc.md
|
|
||
| asserts.false(env, types.is_file(99)) | ||
| asserts.false(env, types.is_file("")) | ||
| asserts.false(env, types.is_file(set())) |
Collaborator
There was a problem hiding this comment.
Here and everywhere below - please remove usage of set() because it requires Bazel 8.x (skylib is supposed to be compatible down to Bazel 7).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While these types cannot be created in the loading phase (i.e.
value = type(File())) for internally consistent type checking, these type rituals allow for a central definition of how/where this type checking can be governed, allowing for future changes, etc to all become generationally compatible as appropriate.