Don't update the baseline configuration with --noallow_analysis_cache_discard#28510
Don't update the baseline configuration with --noallow_analysis_cache_discard#28510fmeum wants to merge 1 commit intobazelbuild:masterfrom
--noallow_analysis_cache_discard#28510Conversation
fmeum
requested review from
aranguyen,
gregestren and
susinmotion
and removed request for
a team and
aranguyen
|
@bazel-io fork 9.1.0 |
github-actions
bot
added
team-Configurability
…e_discard` Before this change, large parts of the analysis cache would be invalidated even with `--noallow_analysis_cache_discard`.
fmeum
force-pushed
the
skygraft-fix-no-discard
branch
from
4c8a50d to
fafccec
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes an issue where the analysis cache was being invalidated even when --noallow_analysis_cache_discard was used. The fix correctly moves the call to setBaselineConfiguration to after the check for whether the cache should be discarded, preventing premature invalidation. The accompanying test changes are excellent, verifying not only that the build fails as expected but also that the cached configured target is not invalidated. The changes are correct and improve the reliability of the analysis cache behavior.
|
@bazel-io fork 9.0.1 |
This change just moves setting the baseline configuration from before the |
|
Yes, that's all it takes to avoid the invalidation |
|
@gregestren Should we import this now? |
iancha1992
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
…e_discard` (bazelbuild#28510) Before this change, large parts of the analysis cache would be invalidated even with `--noallow_analysis_cache_discard`. Closes bazelbuild#28510. PiperOrigin-RevId: 884451995 Change-Id: Ie03a441be4189cd852afaea68a7069c3fd603638
3 participants
Before this change, large parts of the analysis cache would be invalidated even with
--noallow_analysis_cache_discard.