Reject dictionaries passed as lists#28969
Open
keith wants to merge 1 commit intobazelbuild:masterfrom
Open
Conversation
Previously it was valid to pass a dictionary to a starlark attribute defined with `attr.string_list`. In this case it would be ignored. Now it is rejected. Fixes bazelbuild#17553
github-actions
bot
added
the
awaiting-review
Collaborator
|
Prior to this PR, was it really ignored or turned into a list of its keys? |
Member
Author
|
you're right, it turned the list into its keys. i thought i had checked that. so this example: cc_library(
name = "foo",
srcs = ["foo.cc"],
copts = ["-v"],
defines = {"FOO": "bar"},
)gets I think that means we should merge but not try to cherry pick and let this happen in 10.x. wdyt? |
Member
Author
|
if the user wants the existing behavior they can change their code to: defines = {"FOO": "bar"}.keys(),after this change |
fmeum
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it was valid to pass a dictionary to a starlark attribute
defined with
attr.string_list, previously it would take its keys. Nowit is rejected.
Fixes #17553