Skip to content

Correctly cross-jlink Windows arm64 builds#28988

Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum:28941-fix-arm64-build
Closed

Correctly cross-jlink Windows arm64 builds#28988
fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum:28941-fix-arm64-build

Conversation

@fmeum
Copy link
Collaborator

@fmeum fmeum commented Mar 13, 2026

Description

Download the extracted post-JEP 493 jmods for Windows ARM64 and add a safety check to ensure that we don't unknowingly jlink the tool JDK's jmods.

Motivation

Fixes #28941

Build API Changes

No

Checklist

  • I have added tests for the new use cases (if any).
  • I have updated the documentation (if applicable).

Release Notes

RELNOTES: None

@fmeum fmeum force-pushed the 28941-fix-arm64-build branch from 281341e to 13a8f64 Compare March 13, 2026 12:27
@fmeum fmeum requested a review from meteorcloudy March 13, 2026 12:44
@fmeum fmeum marked this pull request as ready for review March 13, 2026 12:44
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Mar 13, 2026
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing, clear AI win!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Mar 13, 2026
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Mar 16, 2026
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Mar 16, 2026
Download the extracted post-[JEP 493](https://openjdk.org/jeps/493) jmods for Windows ARM64 and add a safety check to ensure that we don't unknowingly jlink the tool JDK's jmods.

Fixes bazelbuild#28941

No

- [ ] I have added tests for the new use cases (if any).
- [ ] I have updated the documentation (if applicable).

RELNOTES: None

Closes bazelbuild#28988.

PiperOrigin-RevId: 884547112
Change-Id: If6dadd9a23960d1dcceab6d487f4fc92911288f5
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Mar 16, 2026
Download the extracted post-[JEP 493](https://openjdk.org/jeps/493) jmods for Windows ARM64 and add a safety check to ensure that we don't unknowingly jlink the tool JDK's jmods.

Fixes bazelbuild#28941

No

- [ ] I have added tests for the new use cases (if any).
- [ ] I have updated the documentation (if applicable).

RELNOTES: None

Closes bazelbuild#28988.

PiperOrigin-RevId: 884547112
Change-Id: If6dadd9a23960d1dcceab6d487f4fc92911288f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows-arm64 carries amd64 dlls

2 participants