[9.1.0] Prevent template_ctx.run from using map_directory outputs as inputs.#29014
Open
iancha1992 wants to merge 1 commit intobazelbuild:release-9.1.0from
Open
[9.1.0] Prevent template_ctx.run from using map_directory outputs as inputs.#29014iancha1992 wants to merge 1 commit intobazelbuild:release-9.1.0from
iancha1992 wants to merge 1 commit intobazelbuild:release-9.1.0from
Conversation
This has the following implications: - Internal actions (generated by `template_ctx.run()`) cannot take both subtrees and their parent tree artifacts as inputs, which might be problematic for remote execution as artifacts are "streamed" (potentially causing the same files from the subtree to be added twice). - Ensures encapsulation of the action graph generated by `map_directory()`. For example, internal actions generated within `map_directory(implementation)` themselves depending on the output directories of the same `map_directory()` breaks encapsulation. PiperOrigin-RevId: 884538235 Change-Id: If6c8f4990dea353460de9bdde5f5abca61f8b5a8
github-actions
bot
added
team-Configurability
iancha1992
added
team-Remote-Exec
iancha1992
referenced
this pull request
Mar 16, 2026
This has the following implications: - Internal actions (generated by `template_ctx.run()`) cannot take both subtrees and their parent tree artifacts as inputs, which might be problematic for remote execution as artifacts are "streamed" (potentially causing the same files from the subtree to be added twice). - Ensures encapsulation of the action graph generated by `map_directory()`. For example, internal actions generated within `map_directory(implementation)` themselves depending on the output directories of the same `map_directory()` breaks encapsulation. PiperOrigin-RevId: 884538235 Change-Id: If6c8f4990dea353460de9bdde5f5abca61f8b5a8
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has the following implications:
template_ctx.run()) cannot take both subtrees and their parent tree artifacts as inputs, which might be problematic for remote execution as artifacts are "streamed" (potentially causing the same files from the subtree to be added twice).map_directory(). For example, internal actions generated withinmap_directory(implementation)themselves depending on the output directories of the samemap_directory()breaks encapsulation.PiperOrigin-RevId: 884538235
Change-Id: If6c8f4990dea353460de9bdde5f5abca61f8b5a8
Description
Motivation
Build API Changes
No
Checklist
Release Notes
RELNOTES: None
Commit e46bed7