Use full path for dirname and basename in osx_cc_wrapper.sh.tpl #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteorcloudy
requested review from
armandomontanez,
c-mita,
comius,
pzembrod and
trybka
as code owners
Member
Author
Member
Author
|
@keith I also noticed that apple_support is still using the template from |
pzembrod
approved these changes
Nov 18, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
BEGIN_PUBLIC Copybara import of the project: -- e485793 by Yun Peng <[email protected]>: Use full path for dirname and basename in osx_cc_wrapper.sh.tpl Context: bazelbuild/rules_rust#2998 END_PUBLIC COPYBARA_INTEGRATE_REVIEW=#275 from bazelbuild:meteorcloudy-patch-4 e485793 PiperOrigin-RevId: 697557587 Change-Id: I6ceb3d5f0fd747acb758926750fa48493edbdf3e
Member
Author
|
Merged at 475a353 |
Member
|
yes once there's a release with this change we could change that one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: bazelbuild/rules_rust#2998