Skip to content

Add DefaultInfo provider to kt_compiler_plugin and kt_plugin_cfg deps list #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add DefaultInfo provider to kt_compiler_plugin and kt_plugin_cfg deps list #1363

wants to merge 1 commit into from

Conversation

rbeazleyspot
Copy link
Contributor

This is to enable #1362.

With this change in place you can do something like

kt_compiler_plugin(
    name = "jetpack_compose_compiler_plugin",
    id = "androidx.compose.compiler.plugins.kotlin",
    options = {
        "sourceInformation": "true",  # Required for AS Layout Inspector, disable for release builds
        "stabilityConfigurationPath": "$(locations :stability_config)",
    },
    target_embedded_compiler = True,
    visibility = ["//visibility:public"],
    deps = [
        ":stability_config",
        "@maven_rules_kotlin_example//:org_jetbrains_kotlin_kotlin_compose_compiler_plugin_embeddable",
    ],
)

filegroup(
    name = "stability_config",
    srcs = ["stability.conf"],
)

I tested this by modifying examples/jetpack_compose //app:compose_example_app with a locally built version of the rules (the example code above was lifted from that)

@rbeazleyspot
Copy link
Contributor Author

@restingbull WDYT ? think it aligns with your current changes?

@restingbull
Copy link
Collaborator

I meant to follow the convention for data? deps is generally reserved for known types, rather than arbitrary files.

Though, we'll need to pull DefaultInfo off the deps as well. The data attribute has a bit of a cursed history.

@rbeazleyspot rbeazleyspot mentioned this pull request Sep 17, 2025
Merged
@rbeazleyspot
Copy link
Contributor Author

I meant to follow the convention for data? deps is generally reserved for known types, rather than arbitrary files.

Though, we'll need to pull DefaultInfo off the deps as well. The data attribute has a bit of a cursed history.

i've tried this in #1364

i didnt add DefaultInfo to the deps, is it definitely needed?

@restingbull
Copy link
Collaborator

I meant to follow the convention for data? deps is generally reserved for known types, rather than arbitrary files.
Though, we'll need to pull DefaultInfo off the deps as well. The data attribute has a bit of a cursed history.

i've tried this in #1364

i didnt add DefaultInfo to the deps, is it definitely needed?
You need to merge the runfiles from each dependency to get their data dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahumesky ahumesky Awaiting requested review from ahumesky ahumesky is a code owner

@cgruber cgruber Awaiting requested review from cgruber cgruber is a code owner

@restingbull restingbull Awaiting requested review from restingbull restingbull is a code owner

@Bencodes Bencodes Awaiting requested review from Bencodes Bencodes is a code owner

@nkoroste nkoroste Awaiting requested review from nkoroste nkoroste is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbeazleyspot @restingbull