Add data attr to kt_plugin_cfg and kt_compiler_plugin #1364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbeazleyspot
requested review from
ahumesky,
cgruber,
restingbull,
Bencodes and
nkoroste
as code owners
|
if this looks good I can make the PR mergable |
|
Looks good! Can you add a usecase to the |
hows bb4f777 look? |
restingbull
approved these changes
Sep 19, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative for #1363 using data attribute
This adds a data attribute to kt_plugin_cfg and kt_compiler_plugin
ctx.expand_location is curried with the targets listed in data
tested here using bazelisk build //app:compose_example_app