Add Almalinux 9.5 as a supported toolchain version#940
Add Almalinux 9.5 as a supported toolchain version#940nicbadiu wants to merge 2 commits intobazelbuild:mainfrom
Conversation
| ] | ||
|
|
||
| if debuginfo_type in ["fedora40", "centos7", "centos9", "almalinux9.3"]: | ||
| if debuginfo_type in ["fedora40", "centos7", "centos9", "almalinux9.3", "almalinux9.5"]: |
There was a problem hiding this comment.
This will be unmaintainable at some point.
Let's fix this rather than add to the clutter.
How about you change the configure to add a new property besides debuginfo_type. Something like
- debuginfo_type remains the name of the type
- debuginfo_no_source_packates: set to true for those where we set debuginfo_type. Like here
OR.... why do we even care about the type. It looks like we always want to undefine debugsrc_pkgs if we have set debuginfo_type. So perhaps this can just reduce to
if debuginfo_type:
args += ...
There was a problem hiding this comment.
There's a few nichy behaviour that this controls. That said, from what we've observed so far it looks like there's two variants (fedora (40?) vs alma, centos, etc). Originally when I wrote this I was concerned that there might be more variation, but it increasingly feels like this can be simplified down to this until we get any indications otherwise.
Thoughts?
There was a problem hiding this comment.
This change is definitely the 'fix' for this behavior - and is based on empirical testing for Almalinux 9.5
We are using a forked version so there is no urgency to have this merged upstream.
Perhaps we should first clarify what problems this is trying to address and pause this PR and cancel it once we agree on the way to handle the problem at hand in a more future proof manner.
There was a problem hiding this comment.
I will defer the opinion about what is right to you two. I don't build enough RPMs to on enough platforms to have anything useful to say. Other than the desired to have conditional logic based on the property of something rather than the name of the thing.
There was a problem hiding this comment.
The need to separate is only in terms of Fedora vs CentOS as agreed offline.
Superseding this PR with #942
No description provided.