Skip to content

Commit 935e5ee

Browse files
Build and upload s390x-unknown-linux-gnu crate_universe binary to releases (#3462)
When building envoy on s390x, I get an error when trying to download the cargo-bazel binary because it is not published to github releases (see example message below). This PR adds s390x-unknown-linux-gnu to the list of targets to release. Error message: ```bash ERROR: /home/jalbrecht/.cache/bazel/_bazel_jalbrecht/6fade89f6c57252e6093cc46d35caeb2/external/rules_rust/crate_universe/private/generate_utils.bzl:60:13: An error occurred during the fetch of repository 'dynamic_modules_rust_sdk_crate_index': Traceback (most recent call last): File "/home/jalbrecht/.cache/bazel/_bazel_jalbrecht/6fade89f6c57252e6093cc46d35caeb2/external/rules_rust/crate_universe/private/crates_repository.bzl", line 28, column 48, in _crates_repository_impl generator, generator_sha256 = get_generator(repository_ctx, host_triple.str) File "/home/jalbrecht/.cache/bazel/_bazel_jalbrecht/6fade89f6c57252e6093cc46d35caeb2/external/rules_rust/crate_universe/private/generate_utils.bzl", line 60, column 13, in get_generator fail(( Error in fail: No generator URL was found either in the `CARGO_BAZEL_GENERATOR_URL` environment variable or for the `s390x-unknown-linux-gnu` triple in the `generator_urls` attribute ERROR: Error computing the main repository mapping: no such package '@@dynamic_modules_rust_sdk_crate_index//': No generator URL was found either in the `CARGO_BAZEL_GENERATOR_URL` environment variable or for the `s390x-unknown-linux-gnu` triple in the `generator_urls` attribute ```
1 parent ec35284 commit 935e5ee

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

.github/workflows/release.yaml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,9 @@ jobs:
5757
- os: windows-2022
5858
env:
5959
TARGET: "aarch64-pc-windows-msvc"
60+
- os: ubuntu-22.04
61+
env:
62+
TARGET: "s390x-unknown-linux-gnu"
6063
- os: macOS-13
6164
env:
6265
TARGET: "x86_64-apple-darwin"
@@ -217,6 +220,15 @@ jobs:
217220
asset_name: cargo-bazel-aarch64-unknown-linux-gnu
218221
asset_path: ${{ github.workspace }}/crate_universe/target/artifacts/aarch64-unknown-linux-gnu/cargo-bazel
219222
asset_content_type: application/octet-stream
223+
- name: "Upload s390x-unknown-linux-gnu"
224+
uses: actions/upload-release-asset@v1
225+
env:
226+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
227+
with:
228+
upload_url: ${{ steps.rules_rust_release.outputs.upload_url }}
229+
asset_name: cargo-bazel-s390x-unknown-linux-gnu
230+
asset_path: ${{ github.workspace }}/crate_universe/target/artifacts/s390x-unknown-linux-gnu/cargo-bazel
231+
asset_content_type: application/octet-stream
220232
- name: "Upload x86_64-apple-darwin"
221233
uses: actions/upload-release-asset@v1
222234
env:

0 commit comments

Comments
 (0)