wasm_bindgen: allow target name with directory #2758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I ended up needing to add the |
matt-duch
force-pushed
the
wasm_bindgen-directory-prefix-fix
branch
from
52e9b60 to
ec0f0f9
Compare
Collaborator
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
This generally LGTM, but two questions:
- Can you do a string replacement of
/->_rather than taking the basename, as it's more documenting and less likely to lead to conflicts? - Can you add a test (i.e. a target which didn't build without this change, and does with)?
Thanks!
matt-duch
force-pushed
the
wasm_bindgen-directory-prefix-fix
branch
from
ec0f0f9 to
5e6e2a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the current logic for setting
--out-dirand--out-name, it seems that the intention is to infer those from the target name. However, if a prefix is specified for the name (pkg/custom),out-diris set as expected (pkg), but that directory prefix is also set inout-name(pkg/custom). causing the build command to fail when it appends the two and ends up withpkg/pkg/custom).This approach sets
out-nameto be the last path segment only.