Skip to content

Conversation

@GregBowyer
Copy link
Contributor

I am pretty sure the argument given to protoc_gen_prost is wrong, file descriptors are not present in artifacts.

Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting this didn't fail before. Is there some kind of regression test you could add with this change?

@GregBowyer
Copy link
Contributor Author

GregBowyer commented Nov 13, 2024

Turns out I misunderstood what programs are being invoked, this can be added to the toolchain if needed.

  rust_prost_toolchain(
      name = "prost_toolchain_impl",
      prost_plugin = "@crate_index//:protoc-gen-prost__protoc-gen-prost",
      prost_runtime = ":prost_runtime",
      prost_types = "@crate_index//:prost-types",
┃     prost_opts = [
┃         # For making sure File descriptor sets are added"file_descriptor_set"
┃     ],
      proto_compiler = "@protobuf//:protoc",
      tonic_plugin = "@crate_index//:protoc-gen-tonic__protoc-gen-tonic",
      tonic_runtime = ":tonic_runtime",
  )

  toolchain(
      name = "prost_toolchain",
      toolchain = "prost_toolchain_impl",
      toolchain_type = "@rules_rust//proto/prost:toolchain_type",
  )

I think this is an incorrect PR; I dont know if this should be the default for rules_rust or not.

@GregBowyer GregBowyer closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants