fix!: correctly determine crate dependencies and features common to all supported targets #3006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-heller
force-pushed
the
conditional-common
branch
from
8ebadda to
a7095dc
Compare
Currently, "common" deps and features in selects in generated lockfiles are not always common to all target platforms in the presence of conditional dependencies. This change ensures that common deps and features for a crate are common to all supported targets, not just those targets for which the crate dependency is enabled.
max-heller
force-pushed
the
conditional-common
branch
from
a7095dc to
0ad7a77
Compare
Contributor
Author
|
I could've sworn this was needed for a conditional compilation setup but things seem to be working without it so maybe the current implementation is sufficient after all. Closing unless the need arises again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, "common" deps and features in selects in generated lockfiles are not always common to all target platforms in the presence of conditional dependencies. This change ensures that common deps and features for a crate are common to all supported targets, not just those targets for which the crate dependency is enabled.
Unfortunately this results in a size explosion for some generated lockfiles. I believe this is mostly because the examples consider all target triples, and certain triples (in particular,
wasm32-unknown-unknownforexamples/crate_universe/multi_package/cargo-bazel-lock.json) break the commonality. Whensupported_platform_triplesis specified, the impact should be less severe.