Fix Compiling for release for windows #3398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ograff
force-pushed
the
fix_windows
branch
2 times, most recently
from
e5b00b3 to
2c11bf3
Compare
UebelAndre
requested changes
Apr 8, 2025
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
Actually, why not gate the entire release stage vs each step?
Contributor
Author
|
Looks like windows isn't actually working (see #3397)
|
Avoid failures of the release process by running everything except for the release creation and artifact upload when making or merging a PR that bumps the release version.
UebelAndre
requested changes
Apr 8, 2025
UebelAndre
reviewed
Apr 8, 2025
UebelAndre
reviewed
Apr 8, 2025
UebelAndre
requested changes
Apr 8, 2025
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
I think https://github.com/bazelbuild/rules_rust/pull/3398/files#diff-e426ed45842837026e10e66af23d9c7077e89eacbe6958ce7cb991130ad05adaR96 should just be updated to
echo "startup --output_user_root=C:/tmp" > ./user.bazelrc
echo "startup --windows_enable_symlinks" > ./user.bazelrc
echo "build --enable_runfiles" > ./user.bazelrc
There are other issues that will prevent the use of runfiles from working on windows.
UebelAndre
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.