Skip to content

Build and upload s390x-unknown-linux-gnu crate_universe binary to releases #3462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2025
Merged

Build and upload s390x-unknown-linux-gnu crate_universe binary to releases #3462

merged 1 commit into from
Aug 28, 2025

Conversation

jonathan-albrecht-ibm
Copy link
Contributor

When building envoy on s390x, I get an error when trying to download the cargo-bazel binary because it is not published to github releases (see example message below).

This PR adds s390x-unknown-linux-gnu to the list of targets to release.

Error message:

ERROR: /home/jalbrecht/.cache/bazel/_bazel_jalbrecht/6fade89f6c57252e6093cc46d35caeb2/external/rules_rust/crate_universe/private/generate_utils.bzl:60:13: An error occurred during the fetch of repository 'dynamic_modules_rust_sdk_crate_index':
   Traceback (most recent call last):
        File "/home/jalbrecht/.cache/bazel/_bazel_jalbrecht/6fade89f6c57252e6093cc46d35caeb2/external/rules_rust/crate_universe/private/crates_repository.bzl", line 28, column 48, in _crates_repository_impl
                generator, generator_sha256 = get_generator(repository_ctx, host_triple.str)
        File "/home/jalbrecht/.cache/bazel/_bazel_jalbrecht/6fade89f6c57252e6093cc46d35caeb2/external/rules_rust/crate_universe/private/generate_utils.bzl", line 60, column 13, in get_generator
                fail((
Error in fail: No generator URL was found either in the `CARGO_BAZEL_GENERATOR_URL` environment variable or for the `s390x-unknown-linux-gnu` triple in the `generator_urls` attribute
ERROR: Error computing the main repository mapping: no such package '@@dynamic_modules_rust_sdk_crate_index//': No generator URL was found either in the `CARGO_BAZEL_GENERATOR_URL` environment variable or for the `s390x-unknown-linux-gnu` triple in the `generator_urls` attribute

@jonathan-albrecht-ibm
Copy link
Contributor Author

Gentle ping. Anyone have time to look at this PR?

UebelAndre
UebelAndre approved these changes Jul 29, 2025
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me!

@UebelAndre
Copy link
Collaborator

Needs a rebase though

@jonathan-albrecht-ibm
Copy link
Contributor Author

Thanks for looking at this @UebelAndre. I have rebased it.

@jonathan-albrecht-ibm
Copy link
Contributor Author

Hi @UebelAndre, I have rebased this PR again. Would it be possible to merge it after the checks have completed?

@UebelAndre UebelAndre added this pull request to the merge queue Aug 28, 2025
Merged via the queue into bazelbuild:main with commit 935e5ee Aug 28, 2025
15 checks passed
@jonathan-albrecht-ibm
Copy link
Contributor Author

Thanks for reviewing and merging @UebelAndre!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UebelAndre UebelAndre UebelAndre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathan-albrecht-ibm @UebelAndre