Use default env on rustc compile actions to allow bash scripts for linker #3556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nker The default env has no PATH available, which causes compilation failures on MacOS where the linker from rules_cc toolchain is a wrapper bash script with a '/usr/bin/env bash' shebang, which hence cannot find bash See bazelbuild#3482
|
I missed the discussion in #3535 (searched issues but not PRs 🤦♂️); close this if you wish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3482 for context.
I accept that this may not be merged as-is, as using
use_default_shell_envopens the sandbox to other env vars affecting caching etc. However, gettingPATHinto the sandbox another way requires a bit more discussion, which I hope we can have here and I can amend PR.Possible alternatives:
ctx.configuration.default_shell_envis empty, so that's no usecc_common.get_environment_variables()for the linkerrepository_ctx.which(bash)to embed the correct absolute path to bash into cc_wrapper.sh, then no changes are required here potentially