Skip to content

Do not include libraries when compiling #3801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krasimirgg merged 3 commits into from
Jan 16, 2026
+7 −6
Merged

Do not include libraries when compiling #3801

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
038569e
Do not include libraries when compiling
hlopko Jan 12, 2026
5543f6b
Merge branch 'main' into no_libs_for_compilation
krasimirgg Jan 14, 2026
f46d074
Merge branch 'main' into no_libs_for_compilation
hlopko Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions rust/private/rustc.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,12 +753,12 @@ def collect_inputs(
# Pass linker inputs only for linking-like actions, not for example where
# the output is rlib. This avoids quadratic behavior where transitive noncrates are
# flattened on each transitive rust_library dependency.
additional_transitive_inputs = []
libs_from_linker_inputs = []
ambiguous_libs = {}
if crate_info.type not in ("lib", "rlib"):
linker_inputs = dep_info.transitive_noncrates.to_list()
ambiguous_libs = _disambiguate_libs(ctx.actions, toolchain, crate_info, dep_info, use_pic)
additional_transitive_inputs = _collect_libs_from_linker_inputs(linker_inputs, use_pic) + [
libs_from_linker_inputs = _collect_libs_from_linker_inputs(linker_inputs, use_pic) + [
additional_input
for linker_input in linker_inputs
for additional_input in linker_input.additional_inputs
Expand Down Expand Up @@ -802,16 +802,17 @@ def collect_inputs(

nolinkstamp_compile_inputs = depset(
nolinkstamp_compile_direct_inputs +
additional_transitive_inputs,
([] if experimental_use_cc_common_link else libs_from_linker_inputs),
transitive = [
runtime_libs,
linker_depset,
crate_info.srcs,
transitive_crate_outputs,
crate_info.compile_data,
dep_info.transitive_proc_macro_data,
toolchain.all_files,
],
] + ([] if experimental_use_cc_common_link else [
runtime_libs,
linker_depset,
]),
)

# Register linkstamps when linking with rustc (when linking with
Expand Down