-
Notifications
You must be signed in to change notification settings - Fork 18
Add support for Dash.js rendered subtitles #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 52 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
dd29347
Feat: Support MSE Subtitles for Low Latency
ryanmccartney f9b1227
Add tests for new subtitle type
ryanmccartney 80d4851
Subtitles: low-latency docs
ryanmccartney 0d68c69
Subtitles: low-latency docs
ryanmccartney 033bcc3
Merge branch 'master' of https://github.com/ryanmccartney/bigscreen-p…
ryanmccartney 6279f29
Don't require a captions object when dashSubtitles override is used
ryanmccartney db5e2d6
Add tests for DashSubtitles
ryanmccartney 40d95d8
Merge branch 'bbc:master' into dash-subtitles
ryanmccartney 3f65696
Rename DashSubs to EmbeddedSubs
ryanmccartney 2e5d782
Merge branch 'master' into dash-subtitles
tom-coward 4c6edf7
Fix merge (missing })
tom-coward 485ca68
Wait for media player to be ready before enabling embedded subtitles
tom-coward 591a553
Pass IMSCjs style options through BSP to embeddedsubtitles
ryanmccartney 56c8386
Add customisation to embedded subtitles
ryanmccartney d6b0cc1
Merge branch 'master' of https://github.com/bbc/bigscreen-player into…
ryanmccartney 629821a
Merge branch 'master' into embedded-subtitles
ryanmccartney 6a605b8
Alias smp-imsc in dev and build
ryanmccartney 4e08ddc
Add TTML Rendering Div if embedded
ryanmccartney 04aceba
Add example subtitle using smp-imsc to embedded subs
ryanmccartney a78255b
Fix imports
ShiningTrapez 74364cf
Change call order
ryanmccartney 793a99d
Move div creation to mse-strategy
ryanmccartney e132fa3
Add tests for div creation
ryanmccartney ce6d72b
Add observer and cleanup afterwards
ryanmccartney 15c4063
temp autoStart for tests
ryanmccartney 49bebb4
Handle enable subtitles on start
ryanmccartney 3cbb3b6
Fix Autostart
ShiningTrapez 7aa6213
Improved isSubtitlesAvailable for embedded subs
ryanmccartney 0a2f49d
Merge branch 'master' into embedded-subtitles
ryanmccartney f3cd971
Always start embedded subs strategy in embedded mode
ryanmccartney 094e3c9
Apply sub styles immediately
ryanmccartney abaf8ce
Apply customisation immediately test
ShiningTrapez 0eab88c
Wait for media player before starting subs
ryanmccartney 559e373
Check if text track has id 888 before starting it
ryanmccartney 19306e8
Add a debug line for text tracks
ryanmccartney 6cafbff
fix: use Dash.js apis
eirikbjornr 189d442
chore: undo changes to dev runner
eirikbjornr dfc8206
Don't double transform styles
ryanmccartney 885a021
Tidy up customise function
ryanmccartney 2e4d075
console.log style options
ryanmccartney 1d5ca46
console.log style options
ryanmccartney c3a0a23
Remove console.log
ryanmccartney 763f0a2
Update dash.js version from branch
ryanmccartney 44a34ae
Update Dash.js version
ryanmccartney d8657cb
Update Dash.js version from branch
ryanmccartney 674c51a
Attempt to fix Race Condition
ShiningTrapez 288f74f
Revert "Attempt to fix Race Condition"
ShiningTrapez b8309e2
Printf Debugging
ShiningTrapez 4f981c4
Printf Debugging++
ShiningTrapez 616943c
Log the element
ShiningTrapez f1c23af
Remove logging
ryanmccartney cc81b69
Update Dash.js back to release
ryanmccartney 40f667e
Merge main
ShiningTrapez f3572a3
Attach Subs Element before source
ShiningTrapez 0e2ae01
Set up subtitles element in `setUpMediaPlayer`
ShiningTrapez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.