-
Notifications
You must be signed in to change notification settings - Fork 262
[WS-1377]: Add speakable Schema Markup for Select World Service Pages #13591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WS-1377]: Add speakable Schema Markup for Select World Service Pages #13591
Conversation
| seoTitle, | ||
| type, | ||
| }: { | ||
| service: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use the Services type here.
| if (!SPEAKABLE_ENABLED_SERVICES.includes(service)) return null; | ||
|
|
||
| const speakableXpaths: SpeakableSpecification[] = []; | ||
| if (seoTitle) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of checking if seoTitle exists and then checking the length and returning null if 0, could we bail out earlier with just if (!seoTitle) return null and then remove any of the length checks?
amoore108
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments, looks good!
…-most-read-pages
Resolves JIRA: https://bbc.atlassian.net/browse/WS-1377
Summary
Adds support for the
SpeakableSpecificationschema to theLinkedDatacomponent fo Hindi:This enables tools like Google Assistant or AI Overviews to identify which parts of the page are appropriate for text-to-speech, improving accessibility and discoverability.
Speakable support is temporarily limited to Hindi service only - other services to be added in the future.
Code changes
SpeakableSpecificationschema support to theLinkedDatacomponent for the Hindi service.Developer Checklist
Testing
Ready-For-Test, Local)Ready-For-Test, Test)Ready-For-Test, Preview)Ready-For-Test, Live)Additional Testing Steps
======
Useful Links