FIX: not sure if this year needs updating... #13691
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Moment Timezone include range so builds continue to ship required timezone data now that the configured end year had fallen behind.
Changes:
- Bumps
MomentTimezoneIncludeendYearfrom 2025 to 2026 in Next.js config.
|
|
||
| config.plugins.push( | ||
| new MomentTimezoneInclude({ startYear: 2010, endYear: 2025 }), | ||
| new MomentTimezoneInclude({ startYear: 2010, endYear: 2026 }), |
There was a problem hiding this comment.
Hard-coding endYear means this config will require yearly maintenance and is easy to forget (as happened with 2025). Consider deriving endYear dynamically (e.g., from the current year, optionally with a small buffer like currentYear + 1) so the build won’t silently start excluding future timezone data.
|
There are a few other instances of this in Cypress and in the Express app webpack config that'll need updated too. Curious if this is doing much though if we haven't noticed any odd behaviour in the last month? |
|
|
||
| config.plugins.push( | ||
| new MomentTimezoneInclude({ startYear: 2010, endYear: 2025 }), | ||
| new MomentTimezoneInclude({ startYear: 2010, endYear: 2026 }), |
There was a problem hiding this comment.
We could probably use endYear: new Date().getFullYear() ?
There was a problem hiding this comment.
maybe. Wonder if there would be a performance hit there
4 participants
... but the year was set to last year