fix: no quickloop autotake on parts that were running for a long time

Author: Mint de Wit

meteor/server/publications/lib/quickLoop.ts

@@ -8,7 +8,7 @@ import {
 import { MarkerPosition, compareMarkerPositions } from '@sofie-automation/corelib/dist/playout/playlist'
 import { ProtectedString, unprotectString } from '@sofie-automation/corelib/dist/protectedString'
 import { DEFAULT_FALLBACK_PART_DURATION } from '@sofie-automation/shared-lib/dist/core/constants'
-import { generateTranslation } from '../../../lib/lib'
+import { generateTranslation, getCurrentTime } from '../../../lib/lib'
 import { DBStudio } from '@sofie-automation/corelib/dist/dataModel/Studio'
 import { DBPartInstance } from '@sofie-automation/corelib/dist/dataModel/PartInstance'
 import { DBSegment } from '@sofie-automation/corelib/dist/dataModel/Segment'
@@ -48,7 +48,8 @@ export function modifyPartForQuickLoop(
 	playlist: Pick<DBRundownPlaylist, 'quickLoop'>,
 	studio: Pick<DBStudio, 'settings'>,
 	quickLoopStartPosition: MarkerPosition | undefined,
-	quickLoopEndPosition: MarkerPosition | undefined
+	quickLoopEndPosition: MarkerPosition | undefined,
+	canSetAutoNext = () => true
 ): void {
 	const partPosition = findPartPosition(part, segmentRanks, rundownRanks)
 	const isLoopDefined = quickLoopStartPosition && quickLoopEndPosition
@@ -71,9 +72,47 @@ export function modifyPartForQuickLoop(
 			}
 		}
 	}
+	if (!canSetAutoNext()) return
 	part.autoNext = part.autoNext || (isLoopingOverriden && (part.expectedDuration ?? 0) > 0)
 }
 
+export function modifyPartInstanceForQuickLoop(
+	partInstance: Omit<DBPartInstance, 'part.privateData'>,
+	segmentRanks: Record<string, number>,
+	rundownRanks: Record<string, number>,
+	playlist: Pick<DBRundownPlaylist, 'quickLoop'>,
+	studio: Pick<DBStudio, 'settings'>,
+	quickLoopStartPosition: MarkerPosition | undefined,
+	quickLoopEndPosition: MarkerPosition | undefined
+): void {
+	// note that the logic for when a part does not do autonext in quickloop should reflect the logic in the QuickLoopService in job worker
+	const canAutoNext = () => {
+		const start = partInstance.timings?.plannedStartedPlayback
+		if (start !== undefined && partInstance.part.expectedDuration) {
+			// date.now - start = playback duration, duration + offset gives position in part
+			const playbackDuration = getCurrentTime() - start
+
+			// If there is an auto next planned soon or was in the past
+			if (partInstance.part.expectedDuration - playbackDuration < 0) {
+				return false
+			}
+		}
+
+		return true
+	}
+
+	modifyPartForQuickLoop(
+		partInstance.part,
+		segmentRanks,
+		rundownRanks,
+		playlist,
+		studio,
+		quickLoopStartPosition,
+		quickLoopEndPosition,
+		canAutoNext // do not adjust the part instance if we have passed the time where we can still enable auto next
+	)
+}
+
 export function findMarkerPosition(
 	marker: QuickLoopMarker,
 	fallback: number,

meteor/server/publications/partInstancesUI/publication.ts

@@ -28,7 +28,12 @@ import { protectString } from '@sofie-automation/corelib/dist/protectedString'
 import { Match } from '../../../lib/check'
 import { RundownReadAccess } from '../../security/rundown'
 import { DBPartInstance } from '@sofie-automation/corelib/dist/dataModel/PartInstance'
-import { extractRanks, findMarkerPosition, modifyPartForQuickLoop, stringsToIndexLookup } from '../lib/quickLoop'
+import {
+	extractRanks,
+	findMarkerPosition,
+	modifyPartInstanceForQuickLoop,
+	stringsToIndexLookup,
+} from '../lib/quickLoop'
 
 interface UIPartInstancesArgs {
 	readonly playlistActivationId: RundownPlaylistActivationId
@@ -183,8 +188,8 @@ export async function manipulateUIPartInstancesPublicationData(
 			invalidatedSegmentsSet.has(partInstance.segmentId) ||
 			invalidatedPartInstancesSet.has(partInstance._id)
 		) {
-			modifyPartForQuickLoop(
-				partInstance.part,
+			modifyPartInstanceForQuickLoop(
+				partInstance,
 				segmentRanks,
 				rundownRanks,
 				playlist,

packages/job-worker/src/playout/model/services/QuickLoopService.ts

@@ -14,6 +14,7 @@ import { PlayoutPartInstanceModel } from '../PlayoutPartInstanceModel'
 import { JobContext } from '../../../jobs'
 import { clone } from '@sofie-automation/corelib/dist/lib'
 import { DEFAULT_FALLBACK_PART_DURATION } from '@sofie-automation/shared-lib/dist/core/constants'
+import { getCurrentTime } from '../../../lib'
 
 export class QuickLoopService {
 	constructor(private readonly context: JobContext, private readonly playoutModel: PlayoutModelReadonly) {}
@@ -54,7 +55,23 @@ export class QuickLoopService {
 				expectedDurationWithTransition = fallbackPartDuration
 			}
 		}
-		autoNext = autoNext || (isLoopingOverriden && (expectedDuration ?? 0) > 0)
+
+		const tooCloseToAutonext = () => {
+			const start = partInstanceModel.partInstance.timings?.plannedStartedPlayback
+			if (start !== undefined && partInstanceModel.partInstance.part.expectedDuration) {
+				// date.now - start = playback duration, duration + offset gives position in part
+				const playbackDuration = getCurrentTime() - start
+
+				// If there is an auto next planned
+				if (partInstanceModel.partInstance.part.expectedDuration - playbackDuration < 0) {
+					return true
+				}
+			}
+
+			return false
+		}
+
+		autoNext = autoNext || (isLoopingOverriden && (expectedDuration ?? 0) > 0 && !tooCloseToAutonext())
 		return { autoNext, expectedDuration, expectedDurationWithTransition }
 	}
 

packages/job-worker/src/playout/timeline/rundown.ts

@@ -147,6 +147,18 @@ export function buildTimelineObjsForRundown(
 			currentPartEnable.duration =
 				partInstancesInfo.current.partInstance.part.expectedDuration +
 				partInstancesInfo.current.calculatedTimings.toPartDelay
+
+			if (
+				typeof currentPartEnable.start === 'number' &&
+				currentPartEnable.start + currentPartEnable.duration < getCurrentTime()
+			) {
+				logger.warn('Prevented setting the end of an autonext in the past')
+				// note - this will cause a small glitch on air where the next part is skipped into because this calculation does not account
+				// for the time it takes between timeline generation and timeline execution. That small glitch is preferable to setting the time
+				// very far in the past however. To do this properly we should support setting the "end" to "now" and have that calculated after
+				// timeline generation as we do for start times.
+				currentPartEnable.duration = getCurrentTime() - currentPartEnable.start
+			}
 		}
 		const currentPartGroup = createPartGroup(partInstancesInfo.current.partInstance, currentPartEnable)