Skip to content

fix: reimplement removePartInstance flow for syncChangesToPartInstances SOFIE-238 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Julusian merged 3 commits into from
Mar 19, 2025
Merged

fix: reimplement removePartInstance flow for syncChangesToPartInstances SOFIE-238 #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d6b9fb
chore: refactor `syncChangesToPartInstances` and add some skeleton un…
Julusian Mar 18, 2025
59fb212
fix: reimplement `removePartInstance` flow for `syncChangesToPartInst…
Julusian Mar 18, 2025
721cfed
fix: add `getCurrentTime` to `SyncIngestUpdateToPartInstanceContext`
Julusian Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/blueprints-integration/src/context/syncIngestChangesContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ import type {
IBlueprintPiece,
IBlueprintPieceInstance,
} from '../documents'
import type { IEventContext } from './eventContext'

export interface ISyncIngestUpdateToPartInstanceContext extends IRundownUserContext {
export interface ISyncIngestUpdateToPartInstanceContext extends IRundownUserContext, IEventContext {
/** Sync a pieceInstance. Inserts the pieceInstance if new, updates if existing. Optionally pass in a mutated Piece, to override the content of the instance */
syncPieceInstance(
pieceInstanceId: string,
Expand Down
9 changes: 9 additions & 0 deletions packages/job-worker/src/blueprints/context/SyncIngestUpdateToPartInstanceContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import {
serializePieceTimelineObjectsBlob,
} from '@sofie-automation/corelib/dist/dataModel/Piece'
import { EXPECTED_INGEST_TO_PLAYOUT_TIME } from '@sofie-automation/shared-lib/dist/core/constants'
import { getCurrentTime } from '../../lib'

export class SyncIngestUpdateToPartInstanceContext
extends RundownUserContext
Expand All @@ -40,6 +41,10 @@ export class SyncIngestUpdateToPartInstanceContext

private partInstance: PlayoutPartInstanceModel | null

public get hasRemovedPartInstance(): boolean {
return !this.partInstance
}

constructor(
private readonly _context: JobContext,
contextInfo: ContextInfo,
Expand Down Expand Up @@ -209,4 +214,8 @@ export class SyncIngestUpdateToPartInstanceContext

return unprotectStringArray(pieceInstanceIdsToRemove)
}

getCurrentTime(): number {
return getCurrentTime()
}
}
Loading
Loading