Fix review nipickings :)

Juanjo Alvarez · Juanjo Alvarez · commit 1806bd068647 · 2018-12-09T17:05:34.000+01:00
Signed-off-by: Juanjo Alvarez &lt;juanjo@sourced.tech&gt;
diff --git a/Gopkg.lock b/Gopkg.lock
diff --git a/driver/normalizer/normalizer.go b/driver/normalizer/normalizer.go
@@ -71,14 +71,14 @@ func (op opJoinNamesArray) Check(st *State, n nodes.Node) (bool, error) {
 	}
 
 	tokens := strings.Split(string(s), "::")
-	var qual = uast.QualifiedIdentifier{}
+	var names []uast.Identifier
 
 	for _, t := range tokens {
 		id := uast.Identifier{Name: t}
-		qual.Names = append(qual.Names, id)
+		names = append(names, id)
 	}
 
-	n, err := uast.ToNode(qual.Names)
+	n, err := uast.ToNode(names)
 	if err != nil {
 		return false, err
 	}
diff --git a/driver/normalizer/normalizer_test.go b/driver/normalizer/normalizer_test.go
@@ -44,5 +44,5 @@ func TestOpJoinNamesArray(t *testing.T) {
 	n4, ok := n3.(nodes.String)
 	require.True(t, ok)
 	require.Equal(t, n1, n4)
-	require.Equal(t, string(n4), "a::b::c")
+	require.Equal(t, "a::b::c", string(n4))
 }

Original file line number	Diff line number	Diff line change
`@@ -71,14 +71,14 @@ func (op opJoinNamesArray) Check(st *State, n nodes.Node) (bool, error) {`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`tokens := strings.Split(string(s), "::")`
`74`		`- var qual = uast.QualifiedIdentifier{}`
	`74`	`+ var names []uast.Identifier`
`75`	`75`
`76`	`76`	`for _, t := range tokens {`
`77`	`77`	`id := uast.Identifier{Name: t}`
`78`		`- qual.Names = append(qual.Names, id)`
	`78`	`+ names = append(names, id)`
`79`	`79`	`}`
`80`	`80`
`81`		`- n, err := uast.ToNode(qual.Names)`
	`81`	`+ n, err := uast.ToNode(names)`
`82`	`82`	`if err != nil {`
`83`	`83`	`return false, err`
`84`	`84`	`}`
Original file line number	Diff line number	Diff line change
`@@ -44,5 +44,5 @@ func TestOpJoinNamesArray(t *testing.T) {`
`44`	`44`	`n4, ok := n3.(nodes.String)`
`45`	`45`	`require.True(t, ok)`
`46`	`46`	`require.Equal(t, n1, n4)`
`47`		`- require.Equal(t, string(n4), "a::b::c")`
	`47`	`+ require.Equal(t, "a::b::c", string(n4))`
`48`	`48`	`}`