Skip to content

Conversation

@salomonl
Copy link
Collaborator

  • Update NOMAD interface
  • Add a tutorial on multiobjective optimization

result_infos = Dict()
result_infos[:status] = statusflag
result_infos[:x_sol] = nothing
result_infos[:bbo_sol] = nothing
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amontoison If you have a better name for these attributes, feel free to to tell me. I will change them

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

statistics instead of result_infos?

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 80.43478% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.84%. Comparing base (9e34ce9) to head (db9061d).

Files with missing lines Patch % Lines
src/c_wrappers.jl 67.50% 26 Missing ⚠️
src/core.jl 98.27% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   97.82%   92.84%   -4.98%     
==========================================
  Files           4        4              
  Lines         367      489     +122     
==========================================
+ Hits          359      454      +95     
- Misses          8       35      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amontoison amontoison changed the title Update NOMAD interface to NOMAD 4.5 Update NOMAD interface to NOMAD 4.5.1 Nov 14, 2025
Project.toml Outdated
NOMAD_jll = "= 4.5.1"
Tulip = "0.9"
julia = "1.10"
julia = "^1.10"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
julia = "^1.10"
julia = "1.10"

[compat]
Documenter = "0.27"
julia = "1.6"
Documenter = "^1.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The '^' is not needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I take the last version of the documenter package ? (1.6)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can if you want but I don't think we use any feature from Documenter.jl > 1.0.

@salomonl
Copy link
Collaborator Author

salomonl commented Nov 15, 2025

@amontoison Some parts of the non-covered code in c_wrappers cannot be caught by the tests, since these edge cases are caught before in core.jl. Concerning FreeBSD, it still does not work but in the previous versions, it was also not working.

Tell me if it is ok for you, or you need more things done.

@amontoison
Copy link
Collaborator

Hello @salomonl, do we break the Julia API now.to get the solution? (stats.x_sol).
I want to check if we will break downstream packages or not. If it is the case, we need to bump to v3.0.0.

@salomonl
Copy link
Collaborator Author

salomonl commented Dec 7, 2025

Hey @amontoison The fields from the result struct have changed, so it is a breaking change.

@amontoison amontoison merged commit f218193 into bbopt:master Jan 5, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants