-
Notifications
You must be signed in to change notification settings - Fork 6
Update NOMAD interface to NOMAD 4.5.1 #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
salomonl
commented
Nov 14, 2025
- Update NOMAD interface
- Add a tutorial on multiobjective optimization
src/c_wrappers.jl
Outdated
| result_infos = Dict() | ||
| result_infos[:status] = statusflag | ||
| result_infos[:x_sol] = nothing | ||
| result_infos[:bbo_sol] = nothing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amontoison If you have a better name for these attributes, feel free to to tell me. I will change them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
statistics instead of result_infos?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #83 +/- ##
==========================================
- Coverage 97.82% 92.84% -4.98%
==========================================
Files 4 4
Lines 367 489 +122
==========================================
+ Hits 359 454 +95
- Misses 8 35 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Project.toml
Outdated
| NOMAD_jll = "= 4.5.1" | ||
| Tulip = "0.9" | ||
| julia = "1.10" | ||
| julia = "^1.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| julia = "^1.10" | |
| julia = "1.10" |
docs/Project.toml
Outdated
| [compat] | ||
| Documenter = "0.27" | ||
| julia = "1.6" | ||
| Documenter = "^1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The '^' is not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I take the last version of the documenter package ? (1.6)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can if you want but I don't think we use any feature from Documenter.jl > 1.0.
…OMAD.jl into changes_for_NOMAD_4_5
|
@amontoison Some parts of the non-covered code in c_wrappers cannot be caught by the tests, since these edge cases are caught before in Tell me if it is ok for you, or you need more things done. |
|
Hello @salomonl, do we break the Julia API now.to get the solution? ( |
|
Hey @amontoison The fields from the |