Skip to content

Fix kanban column layout height issue#483

Merged
bborn merged 2 commits intomainfrom
task/1905-fix-kanban-column-layout-height-issue
Mar 3, 2026
Merged

Fix kanban column layout height issue#483
bborn merged 2 commits intomainfrom
task/1905-fix-kanban-column-layout-height-issue

Conversation

@bborn
Copy link
Owner

@bborn bborn commented Mar 2, 2026

Summary

Re-applies the good improvements from reverted PR #478 while fixing the root cause of the kanban layout breakage.

Root cause: PR #478 showed a tmux pane preview for ALL in-progress tasks (processing/queued/blocked), which constantly consumed vertical space and broke the kanban column height calculation. The pane preview should only appear for tasks that actually need input (blocked with a permission prompt).

Key changes:

  • Fix yellow highlight false positives: Rename latestPermissionPromptlatestChoicePrompt, only match "Waiting for permission" entries (not "Waiting for user input" generic idle/end_turn scenarios)
  • Replace reply mode with quick input: Replace replyActive/replyTaskID/replyPaneContent fields with a single quickInputFocused bool
  • Tab key to focus input: Add QuickInput keybinding (Tab) to focus the input field — only works when selected task needs input (has a permission prompt)
  • Esc/Shift+Tab to unfocus: Returns focus to the kanban board
  • Preserve kanban height: Pane preview remains scoped to blocked tasks with permission prompts only, not all in-progress tasks
  • Remove 'r' key hijack: The Retry handler no longer hijacks 'r' to enter reply mode

Test plan

  • go build ./... compiles cleanly
  • go test ./internal/ui/... all tests pass
  • Select a blocked task with permission prompt → should see prompt preview with "y approve N deny tab input enter detail"
  • Tab → input field focuses with "input:" label
  • Type text + Enter → sent to executor
  • Esc → focus returns to kanban
  • Processing task without permission prompt → NO pane preview shown (kanban height preserved)
  • "Waiting for user input" log → NO yellow highlight (false positive fix)

🤖 Generated with Claude Code

bborn and others added 2 commits March 2, 2026 15:36
The reverted PR #478 broke the kanban layout by showing a pane preview
for ALL in-progress tasks (not just blocked ones needing input). This
caused the preview to constantly consume space and break height calc.

Key changes:
- Rename latestPermissionPrompt → latestChoicePrompt, only match
  "Waiting for permission" (not "Waiting for user input" generic
  idle/end_turn) to fix yellow highlight false positives
- Replace replyActive/replyTaskID/replyPaneContent with quickInputFocused
- Add Tab keybinding to focus quick input (only for tasks needing input)
- Esc/Shift+Tab to unfocus, Enter to send, empty Enter to unfocus
- Keep pane preview scoped to blocked tasks with permission prompts
  (not all in-progress tasks), preserving kanban column height
- Remove 'r' key reply mode entry from Retry handler
- Update all tests for new behavior

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…input

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@bborn bborn merged commit 1ec3871 into main Mar 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant