Merged
Conversation
The reverted PR #478 broke the kanban layout by showing a pane preview for ALL in-progress tasks (not just blocked ones needing input). This caused the preview to constantly consume space and break height calc. Key changes: - Rename latestPermissionPrompt → latestChoicePrompt, only match "Waiting for permission" (not "Waiting for user input" generic idle/end_turn) to fix yellow highlight false positives - Replace replyActive/replyTaskID/replyPaneContent with quickInputFocused - Add Tab keybinding to focus quick input (only for tasks needing input) - Esc/Shift+Tab to unfocus, Enter to send, empty Enter to unfocus - Keep pane preview scoped to blocked tasks with permission prompts (not all in-progress tasks), preserving kanban column height - Remove 'r' key reply mode entry from Retry handler - Update all tests for new behavior Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…input Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-applies the good improvements from reverted PR #478 while fixing the root cause of the kanban layout breakage.
Root cause: PR #478 showed a tmux pane preview for ALL in-progress tasks (processing/queued/blocked), which constantly consumed vertical space and broke the kanban column height calculation. The pane preview should only appear for tasks that actually need input (blocked with a permission prompt).
Key changes:
latestPermissionPrompt→latestChoicePrompt, only match"Waiting for permission"entries (not"Waiting for user input"generic idle/end_turn scenarios)replyActive/replyTaskID/replyPaneContentfields with a singlequickInputFocusedboolQuickInputkeybinding (Tab) to focus the input field — only works when selected task needs input (has a permission prompt)Test plan
go build ./...compiles cleanlygo test ./internal/ui/...all tests pass🤖 Generated with Claude Code