dealing with no never treated units in data#229
Merged
pedrohcgs merged 4 commits intobcallaway11:masterfrom Jun 12, 2025
Merged
dealing with no never treated units in data#229pedrohcgs merged 4 commits intobcallaway11:masterfrom
pedrohcgs merged 4 commits intobcallaway11:masterfrom
Conversation
…gin/nt-units-faster-mode-debug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supersedes PR#220 and implements two minor improvements in
did:When the data contain no never-treated units but the user specifies "nevertreated" as the control group,
didnow issues a warning instead of throwing an error. In this situation, the last treated cohort (as defined by gname) is used as a “synthetic” never-treated group. We then drop all observations from periods ≥latest_g. This behavior applies in both the regular and fast estimation modes. Unit tests verify that a warning is raised and that both modes produce identical treatment‐effect estimates.Unit test in test-att_gt.R, Lines 215-226
To prevent spurious warnings in unbalanced panels or repeated cross‐section settings, I’ve added a
fill = TRUEargument when constructing the influence‐function matrix. The warning previously read:All unit tests are passing from my end
