Skip to content

Conversation

@forman
Copy link
Member

@forman forman commented Jan 13, 2025

Refactoring: Making most of the data classes JSON-serializable using JsonSerializable instead of the very naive ToDictMixin.

Checklist (strike out non-applicable):

  • Changes documented in CHANGES.md
  • Related issue exists and is referred to in the PR description and CHANGES.md
  • Added docstrings and API docs for any new/modified user-facing classes and functions
  • Changes/features documented in docs/*
  • Unit-tests adapted/added for changes/features
  • Test coverage remains or increases (target 100%)

@codecov
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.26%. Comparing base (b1596ff) to head (1be1aec).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   95.92%   96.26%   +0.34%     
==========================================
  Files          52       51       -1     
  Lines        2060     2061       +1     
  Branches      269      269              
==========================================
+ Hits         1976     1984       +8     
+ Misses         47       44       -3     
+ Partials       37       33       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forman forman changed the title Introducting JsonSerializable Refactoring: Introducting JsonSerializable Jan 13, 2025
@forman forman marked this pull request as ready for review January 14, 2025 08:09
@forman forman merged commit de5c4e5 into main Jan 14, 2025
6 checks passed
@forman forman deleted the forman-json_serializable branch January 14, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants