Skip to content

Conversation

@forman
Copy link
Member

@forman forman commented Jan 16, 2025

Reduce code duplications for operation classes that can be customized: rules, processors, formatters.
Fixed #21.

Closes #21

Checklist (strike out non-applicable):

  • Changes documented in CHANGES.md
  • Related issue exists and is referred to in the PR description and CHANGES.md
  • Added docstrings and API docs for any new/modified user-facing classes and functions
  • Changes/features documented in docs/*
  • Unit-tests adapted/added for changes/features
  • Test coverage remains or increases (target 100%)

@forman forman changed the title Reduce code duplications for op-like Reduce code duplications Jan 16, 2025
@codecov
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.15%. Comparing base (7803dc0) to head (57e0976).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   96.17%   97.15%   +0.97%     
==========================================
  Files          51       52       +1     
  Lines        2065     2108      +43     
  Branches      270      270              
==========================================
+ Hits         1986     2048      +62     
+ Misses         46       32      -14     
+ Partials       33       28       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forman forman marked this pull request as ready for review January 17, 2025 09:01
@forman forman merged commit aae5a62 into main Jan 17, 2025
6 checks passed
@forman forman deleted the forman-reduce_code_duplications branch January 17, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Referencing objects using form "<module>:<attr>" raises

2 participants