Skip to content

Conversation

@forman
Copy link
Member

@forman forman commented Jan 20, 2025

Added rule "no-empty-chunks".

Checklist (strike out non-applicable):

  • Changes documented in CHANGES.md
  • Related issue exists and is referred to in the PR description and CHANGES.md
  • Added docstrings and API docs for any new/modified user-facing classes and functions
  • Changes/features documented in docs/*
  • Unit-tests adapted/added for changes/features
  • Test coverage remains or increases (target 100%)

@forman forman marked this pull request as ready for review January 20, 2025 13:57
@forman forman merged commit 3e82c2c into main Jan 20, 2025
4 checks passed
@codecov
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.31%. Comparing base (e4f0ee4) to head (4577887).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   97.30%   97.31%   +0.01%     
==========================================
  Files          56       57       +1     
  Lines        2223     2236      +13     
  Branches      304      306       +2     
==========================================
+ Hits         2163     2176      +13     
  Misses         32       32              
  Partials       28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forman forman deleted the forman-write_empty_chunks_rule branch January 25, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants