Skip to content

More consistency #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
forman merged 3 commits into from
Jan 30, 2025
Merged

More consistency #43

forman merged 3 commits into from
Jan 30, 2025

Conversation

@forman
Copy link
Member

@forman forman commented Jan 30, 2025 •
edited
Loading

  • Renamed nodes and node properties for consistency and clarity:

    • renamed DataArrayNode into VariableNode
    • renamed DataArrayNode.data_array into VariableNode.array

  • Changed general use of term verify into validate:

    • prefixed RuleOp methods by validate_ for clarity.
    • renamed XRLint.verify_datasets() into validate_files()
    • renamed Lint.verify_dataset() into validate()

Checklist (strike out non-applicable):

  • Changes documented in CHANGES.md
  • Related issue exists and is referred to in the PR description and CHANGES.md
  • Added docstrings and API docs for any new/modified user-facing classes and functions
  • Changes/features documented in docs/*
  • Unit-tests adapted/added for changes/features
  • Test coverage remains or increases (target 100%)

@forman forman marked this pull request as ready for review January 30, 2025 13:32
@forman forman merged commit 0dd9d85 into main Jan 30, 2025
4 checks passed
@forman forman deleted the forman-vaerify_vs_validate branch January 30, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@forman