Allows creation of HashMLDsaSigner that can sign hashes#655
Open
harrison314 wants to merge 1 commit intobcgit:masterfrom
Open
Allows creation of HashMLDsaSigner that can sign hashes#655harrison314 wants to merge 1 commit intobcgit:masterfrom
harrison314 wants to merge 1 commit intobcgit:masterfrom
Conversation
Collaborator
|
Thanks, @harrison314 . It looks reasonable, though I want to check with bc-java that the approaches are similar. Some initial changes I'd prefer:
|
966e61d to
77c4e4f
Compare
77c4e4f to
da142b2
Compare
Contributor
Author
|
Thanks for the quick response, I've made the required changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
I made modifications that allow you to create a
HashMLDsaSignerthat can be used to sign an existing hash.For proper functionality, it is necessary to accept the merge request #654
I added the same option for
HashSlhDsaSigner.My questions
static HashMLDsaSigner CreateRawSigner(MLDsaParameters parametersWithoutPrehash, bool deterministic, DerObjectIdentifier preHashOid)method or is there a digest OID forpreHashOid?RsaDigestSigner, but I didn't find this check in it.How has this been tested?
Tested with my own application and with changes in #654
Checklist before requesting a review
See also Contributing Guidelines.