Skip to content

[COMP-807] error closing case file #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tom0827 merged 1 commit into from
Feb 18, 2026
Merged

[COMP-807] error closing case file #740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion compliance-api/requirements/dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ pylint-flask
pytest
pytest-cov
pytest-env
pytest-dotenv
pytest-mock
requests
flake8==4.0.1
Expand Down
8 changes: 6 additions & 2 deletions compliance-api/src/compliance_api/services/case_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
from compliance_api.models.complaint import ComplaintStatusEnum
from compliance_api.models.db import db, session_scope
from compliance_api.models.inspection import Inspection as InspectionModel
from compliance_api.models.inspection.inspection_enum import InspectionStatusEnum
from compliance_api.models.order import Order as OrderModel
from compliance_api.models.project import Project as ProjectModel
from compliance_api.models.restorative_justice import RestorativeJustice as RestorativeJusticeModel
Expand Down Expand Up @@ -761,8 +762,11 @@ def _process_case_level_items(case_file_id: int, open_items: dict) -> list:
for row in case_level_query:
if row.inspection_id and row.inspection_id not in all_inspection_ids:
all_inspection_ids.add(row.inspection_id)
# Add all inspection items, regardless of IR status
open_items["inspections"].append(_build_inspection_item(row))
# Only add inspections that are open to the open items list,
# closed inspections are not considered open items but we
# want to track their IDs for enforcement action checks
if row.inspection_status == InspectionStatusEnum.OPEN:
open_items["inspections"].append(_build_inspection_item(row))

if row.complaint_id and row.complaint_id not in processed_complaints:
processed_complaints.add(row.complaint_id)
Expand Down