#5617 - Update PT Exceptions to Align with FT

[CarlyCotton]

Form

• Modified the additional transportation exception formatting with the unordered list to fix alignment of the bullets.
• Updated all exceptions to bring relevant exception fields into the exception panel and included anything relevant from outside the panel (dependant name)
• Maintained the conditional showing of the uploaders within the exceptions based on selecting the situation of the student.
• Removed the '2020 Tax Return Income Panel' panel to just be named 'Tax Return Income Panel'.
• Removed an exception (Student CY Income) that I missed during the exceptions removal ticket.

Verifications

I submitted an application with all exceptions.
All exceptions triggered and when approved resulted in an assessment.
Edited application with no changes to exceptions, all auto-approved.
Edited application with one exception changed and they all auto-approved except for the one.

 "dependantsIncomeTaxApplicationException": {
        "pdDependentUpload": [
          {
            "url": "student/files/testfile-32dfc091-0be4-4fde-8a79-82b4f47deaff.txt",
            "hash": "",
            "name": "testfile-32dfc091-0be4-4fde-8a79-82b4f47deaff.txt",
            "size": 197050,
            "type": "text/plain",
            "storage": "url",
            "originalName": "testfile.txt"
          }
        ],
        "exceptionDescription": "Dependant's income tax - Child 1"
      },
      "dependantsSharedCustodyApplicationException": {
        "exceptionDescription": "Dependant's shared custody - Child 1",
        "dependantCustodyFileUpload": [
          {
            "url": "student/files/testfile-bb911969-3cc0-46e2-a4c6-9b31b6b89657.txt",
            "hash": "",
            "name": "testfile-bb911969-3cc0-46e2-a4c6-9b31b6b89657.txt",
            "size": 197050,
            "type": "text/plain",
            "storage": "url",
            "originalName": "testfile.txt"
          }
        ]
      }

 "transportationApplicationException": {
    "exceptionDescription": "Transportation",
    "additionalTransportKm": 155,
    "transportationCostsFile": [
      {
        "url": "student/files/testfile-6149bf1d-7666-4f51-8fe9-ff0bb01c4bde.txt",
        "hash": "",
        "name": "testfile-6149bf1d-7666-4f51-8fe9-ff0bb01c4bde.txt",
        "size": 197050,
        "type": "text/plain",
        "storage": "url",
        "originalName": "testfile.txt"
      }
    ],
    "additionalTransportOwner": "yes",
    "additionalTransportWeeks": 10,
    "transportationcostsituation": "noLimit",
    "additionalTransportPlacement": "no"
  },
  "citizenshipForBCResidencyApplicationException": {
    "bclivingSituation": "other",
    "exceptionDescription": "Citizenship for B.C. residency",
    "otherLivingSituation": "Very big explanation of my specific situation",
    "otherLivingSituationDocs": [
      {
        "url": "student/files/testfile-9a358606-4185-4d78-a09e-f6d2f1e15ca4.txt",
        "hash": "",
        "name": "testfile-9a358606-4185-4d78-a09e-f6d2f1e15ca4.txt",
        "size": 197050,
        "type": "text/plain",
        "storage": "url",
        "originalName": "testfile.txt"
      }
    ]
  },
  "citizenshipForProtectedPersonsApplicationException": {
    "exceptionDescription": "Citizenship for protected persons",
    "citizenshipVerificationProtectedPerson": [
      {
        "url": "student/files/testfile-2dc58001-660a-459e-9792-8e8d1f76f7ef.txt",
        "hash": "",
        "name": "testfile-2dc58001-660a-459e-9792-8e8d1f76f7ef.txt",
        "size": 197050,
        "type": "text/plain",
        "storage": "url",
        "originalName": "testfile.txt"
      }
    ]
  },
  "marriedCommonLawDomesticViolenceApplicationException": {
    "exceptionDescription": "Married/common-law domestic violence",
    "marriedCommonLawDomesticViolenceExceptionDocuments": [
      {
        "url": "student/files/testfile-eb0218f4-af94-4ce5-9f5d-c73572677031.txt",
        "hash": "",
        "name": "testfile-eb0218f4-af94-4ce5-9f5d-c73572677031.txt",
        "size": 197050,
        "type": "text/plain",
        "storage": "url",
        "originalName": "testfile.txt"
      }
    ]
  }

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Backend Unit Tests Coverage Report

Totals
Statements:	20.1% ( 4572 / 22741 )
Methods:	9.47% ( 262 / 2768 )
Lines:	24.47% ( 3924 / 16039 )
Branches:	9.81% ( 386 / 3934 )

[github-actions]

E2E Workflow Workers Coverage Report

Totals
Statements:	48.25% ( 2712 / 5621 )
Methods:	38.2% ( 285 / 746 )
Lines:	55.11% ( 2049 / 3718 )
Branches:	32.67% ( 378 / 1157 )

[github-actions]

E2E Queue Consumers Coverage Report

Totals
Statements:	79.31% ( 9155 / 11543 )
Methods:	78.42% ( 1181 / 1506 )
Lines:	82.64% ( 6881 / 8326 )
Branches:	63.88% ( 1093 / 1711 )

[github-actions]

E2E SIMS API Coverage Report

Totals
Statements:	65.12% ( 12908 / 19821 )
Methods:	61.77% ( 1514 / 2451 )
Lines:	68.9% ( 9395 / 13635 )
Branches:	53.52% ( 1999 / 3735 )

[andrewsignori-aot]

Is there a reason why dependantsIncomeTaxApplicationException does not follow the same from FT?

Current on PR

Current FT

[andrewsignori-aot]

Nice work, please take a look at the only comment.

[tiago-graf]

LGTM