Skip to content

hotfix ops metrics#1228

Merged
ikethecoder merged 7 commits intodevfrom
hotfix/ops-metrics
Feb 11, 2025
Merged

hotfix ops metrics#1228
ikethecoder merged 7 commits intodevfrom
hotfix/ops-metrics

Conversation

@ikethecoder
Copy link
Member

No description provided.

Copy link
Contributor

@rustyjux rustyjux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new function seems fine. Funny we see this paging issue again - didn't this come up some other time in the last year? or was that another query?

I made a small change to fix an error during npm run build (see https://github.com/bcgov/api-services-portal/actions/runs/13190804790/job/36823280137 - Build Docker Images step).

I can approve, but I have a couple questions:

  1. What issue is this trying to fix?
  2. How do I run the tests? are the more instructions on 'wiring up directly with keycloak'?

@github-actions
Copy link
Contributor

🔔 Friendly reminder: The following reviewers still need to review this PR: @Elson9

PS: @sdqdadat

@ikethecoder
Copy link
Member Author

Before it was hard coded to 1000 records - now it will make multiple paging calls to get a full list.. so it is a preemptive change.. we probably should look at demising listAll in favour of listAllPages at some point to avoid a "mysterious missing records" problem.

The test/integrated folder is adhoc testing and so you have to be in a state where you can run the Portal locally, but instead of running the Portal locally, you run:

npm run ts-build
npm run ts-watch

..in one terminal and this in another:

node dist/test/integrated/batchworker/paging.js

@ikethecoder ikethecoder merged commit 951d551 into dev Feb 11, 2025
5 of 6 checks passed
@ikethecoder ikethecoder deleted the hotfix/ops-metrics branch February 11, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants