APS-4068 - use Postgres 15 instead of Mongo for feature deployments#1354
APS-4068 - use Postgres 15 instead of Mongo for feature deployments#1354
Conversation
|
🔔 Friendly reminder: The following reviewers still need to review this PR: @danebenal, @Elson9, @ikethecoder PS: @sdqdadat |
Elson9
left a comment
There was a problem hiding this comment.
Looks good overall, my only concern is with storage-quota if a PVC is being created for each feature branch
This was the existing pattern. I guess they could all share one PVC but then we hit issues if there are many feature branches and cleanup is trickier. Probably more problematic than PVC per feature branch is that right now old feature deployments aren't being cleaned up (either branches aren't being deleted, or the cleanup failed - I haven't dug into why there are so many). I would like to verify the cleanup workflow works but it needs to get merged into In any case, we can definitely reduce the PVC size. Ever more long-lived feature branches seeing more activity like Aidan's |
Feature deploymentss now use Postgres 15 (public
postgres:15image) instead of MongoDB. Follows the same pattern as e2e (ADAPTER=knex,local/db/keystone-init.sql).Postgres is deployed via inline k8s manifests (Deployment, Service, PVC, init ConfigMap, Keystone-schema Job). There is potential to use a helm chart but this seemed like the least overhead. Updated delete deployment (
ci-remove.yaml) to handle this change.Validation:
devto run in GH)🚀 Feature branch deployment: https://api-services-portal-feature-feature-pg.apps.silver.devops.gov.bc.ca