SIMSBIOHUB-882: Refactor Ingestion Job to support multiple uploads#352
Draft
SIMSBIOHUB-882: Refactor Ingestion Job to support multiple uploads#352
Conversation
|
OpenShift URLs for the PR Deployment:
|
dwhogan
changed the title
upload_id instead of submission_idupload_id
dwhogan
changed the title
upload_id
dwhogan
changed the title
|
dwhogan
added
Ready For Review
mauberti-bc
reviewed
Mar 4, 2026
| * Both IDs travel together through publisher, job handler, validation tracking, | ||
| * and feature insertion. The trigger resolves both before publishing. | ||
| */ | ||
| export interface IngestionJobData { |
Collaborator
There was a problem hiding this comment.
Can we simplify by just passing submission_upload_id?
dwhogan
added
Not Ready For Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
Description of Changes
Update the ingestion jobs that currently take submission_id so they can take submission_upload_id instead.
This makes ingestion upload-scoped, so the same submission_id can be re-published by creating a new upload and running ingestion again without colliding with (or overwriting) prior runs.
Job logging and validation/processing status should be attributable to the specific upload being processed, not the parent submission.
Testing Notes
Run
make test